Skip to content

community-containers - add facerecognition #3999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 9, 2024
Merged

community-containers - add facerecognition #3999

merged 3 commits into from
Jan 9, 2024

Conversation

szaimen
Copy link
Collaborator

@szaimen szaimen commented Jan 3, 2024

@szaimen szaimen added 3. to review Waiting for reviews enhancement New feature or request labels Jan 3, 2024
@szaimen szaimen added this to the next milestone Jan 3, 2024
@szaimen
Copy link
Collaborator Author

szaimen commented Jan 3, 2024

@matiasdelellis I invited you to the repo so that you can review the PR :)

@szaimen szaimen force-pushed the enh/noid/add-facerecognition branch from 399198f to 67fc4b5 Compare January 3, 2024 23:43
@szaimen szaimen mentioned this pull request Jan 3, 2024
Open
@szaimen
Copy link
Collaborator Author

szaimen commented Jan 4, 2024

FYI @pulsejet

szaimen
szaimen commented Jan 4, 2024
View reviewed changes
@szaimen szaimen force-pushed the enh/noid/add-facerecognition branch from 0e982aa to bd3fc82 Compare January 4, 2024 11:19
matiasdelellis
matiasdelellis reviewed Jan 4, 2024
View reviewed changes
Copy link
Collaborator

@matiasdelellis matiasdelellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am still a stranger to nextcloud AIO, therefore I cannot comment more than this.

The only important thing is to remove the background_job command

@szaimen
address review
8fc4113 
Signed-off-by: Simon L <[email protected]>
@szaimen
Copy link
Collaborator Author

szaimen commented Jan 5, 2024

Thanks for the review @matiasdelellis! :)
Should all be resolved with 8fc4113

@szaimen szaimen requested a review from matiasdelellis January 5, 2024 09:53
@szaimen szaimen force-pushed the enh/noid/add-facerecognition branch from 0f97173 to cd5cf86 Compare January 5, 2024 21:38
@szaimen szaimen force-pushed the enh/noid/add-facerecognition branch from cd5cf86 to a126cfc Compare January 5, 2024 21:40
@xieminghuang

This comment was marked as off-topic.

Sign in to view
@szaimen
Copy link
Collaborator Author

szaimen commented Jan 7, 2024

Hi @matiasdelellis does the PR look good to you now? :)
(No testing required as I will take care of this)

@matiasdelellis
Copy link
Collaborator

LGTM...
Let's look for real tests and wait for comments... 😉

Thanks.

@szaimen
Copy link
Collaborator Author

szaimen commented Jan 9, 2024

Thank you @matiasdelellis! :)

@szaimen szaimen merged commit 2dc4358 into main Jan 9, 2024
@delete-merged-branch delete-merged-branch bot deleted the enh/noid/add-facerecognition branch January 9, 2024 09:37
@szaimen szaimen mentioned this pull request Jan 9, 2024
Closed
19 tasks
@oliverhu
Copy link

@szaimen curious on this line - php /var/www/html/occ config:system:set facerecognition.external_model_api_key --value some-super-secret-api-key, probably we should make the key field configurable?

@szaimen
Copy link
Collaborator Author

szaimen commented Jan 10, 2024

@szaimen curious on this line - php /var/www/html/occ config:system:set facerecognition.external_model_api_key --value some-super-secret-api-key, probably we should make the key field configurable?

See #3999 (comment)

@szaimen
Copy link
Collaborator Author

szaimen commented Jan 10, 2024 •
edited
Loading

This is now released with v7.10.0 Beta. Testing and feedback is welcome! See https://github.com/nextcloud/all-in-one#how-to-switch-the-channel and https://github.com/nextcloud/all-in-one/tree/main/community-containers/facerecognition

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matiasdelellis matiasdelellis matiasdelellis approved these changes

Assignees
No one assigned
Labels
3. to review Waiting for reviews enhancement New feature or request
Projects
None yet
Milestone
v7.10.0
Development

Successfully merging this pull request may close these issues.

Request to add pdlib to PECL.
4 participants
@szaimen @xieminghuang @matiasdelellis @oliverhu