Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider configuration-controllable version #4169

Closed
tmc opened this issue Oct 28, 2023 · 2 comments
Closed

Consider configuration-controllable version #4169

tmc opened this issue Oct 28, 2023 · 2 comments
Labels
duplicate This issue or pull request already exists

Comments

@tmc
Copy link

tmc commented Oct 28, 2023

Your feature request related to a problem? Please describe.

It'd be great if the .golangci.yaml (et. al) files could specify the golangci-lint version number and have it resolve missing versions for users. This would make it easier for users to have identical local and CI results with low overhead.

Describe the solution you'd like.

some means of specifying the golangci-lint version in configuration.

Describe alternatives you've considered.

Additional context.

No response

@tmc tmc added the enhancement New feature or improvement label Oct 28, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Oct 28, 2023

Hey, thank you for opening your first Issue ! 🙂 If you would like to contribute we have a guide for contributors.

@bombsimon
Copy link
Member

I think this is a duplicate of #3912, right?

It's been discussed before and my memory says that it's been out of scope for golangci-lint so far. So shameless self promotion but that's why I made gclv as a proof of concept to see how this could work. It allows you to specify the version of golangci-lint in .golangci.yml and use gclv --run as an alias for golangci-lint --run but ensuring the specified version is used.

Feel free to close this if you agree it's a duplicate.

@ldez ldez added duplicate This issue or pull request already exists and removed enhancement New feature or improvement labels Oct 29, 2023
@ldez ldez closed this as completed Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

3 participants