Skip to content

Commit 771091a

Browse files
committed
extension/tools/release: skip validation for dir in zip
TestBuildVSCGO failure causing LUCI post submit failure. For #3533 Change-Id: I11fe1154293ff91b7e06897f7f572f24a9ccc5eb Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/642479 Reviewed-by: Hyang-Ah Hana Kim <[email protected]> kokoro-CI: kokoro <[email protected]> Commit-Queue: Hongxiang Jiang <[email protected]>
1 parent 8b6e6f8 commit 771091a

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

extension/tools/release/release_test.go

+6
Original file line numberDiff line numberDiff line change
@@ -137,6 +137,12 @@ func TestBuildVSCGO(t *testing.T) {
137137
want[platform.goos+"_"+platform.goarch] = true
138138
}
139139
for _, f := range zipReader.File {
140+
// CL 578415 modifies the behavior of archive/zip.Writer.AddFS regarding
141+
// writing headers to zip files.
142+
// See golang/go#66831 for details.
143+
if f.FileInfo().IsDir() {
144+
continue
145+
}
140146
dirname := path.Base(path.Dir(f.Name))
141147
if !want[dirname] {
142148
t.Errorf("unexpected file in zip: %v", f.Name)

0 commit comments

Comments
 (0)