Skip to content

Commit e439b13

Browse files
gopls/internal/util/frob: use binary.LittleEndian.AppendUint{16,32,64}
Complete a TODO. Change-Id: I5ef391754d516a9a7672308e1f7e829789f6ac2e
1 parent a1fbc78 commit e439b13

File tree

1 file changed

+3
-34
lines changed

1 file changed

+3
-34
lines changed

gopls/internal/util/frob/frob.go

Lines changed: 3 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -402,38 +402,7 @@ func (r *reader) bytes(n int) []byte {
402402
type writer struct{ data []byte }
403403

404404
func (w *writer) uint8(v uint8) { w.data = append(w.data, v) }
405-
func (w *writer) uint16(v uint16) { w.data = appendUint16(w.data, v) }
406-
func (w *writer) uint32(v uint32) { w.data = appendUint32(w.data, v) }
407-
func (w *writer) uint64(v uint64) { w.data = appendUint64(w.data, v) }
405+
func (w *writer) uint16(v uint16) { w.data = binary.LittleEndian.AppendUint16(w.data, v) }
406+
func (w *writer) uint32(v uint32) { w.data = binary.LittleEndian.AppendUint32(w.data, v) }
407+
func (w *writer) uint64(v uint64) { w.data = binary.LittleEndian.AppendUint64(w.data, v) }
408408
func (w *writer) bytes(v []byte) { w.data = append(w.data, v...) }
409-
410-
// TODO(adonovan): delete these as in go1.19 they are methods on LittleEndian:
411-
412-
func appendUint16(b []byte, v uint16) []byte {
413-
return append(b,
414-
byte(v),
415-
byte(v>>8),
416-
)
417-
}
418-
419-
func appendUint32(b []byte, v uint32) []byte {
420-
return append(b,
421-
byte(v),
422-
byte(v>>8),
423-
byte(v>>16),
424-
byte(v>>24),
425-
)
426-
}
427-
428-
func appendUint64(b []byte, v uint64) []byte {
429-
return append(b,
430-
byte(v),
431-
byte(v>>8),
432-
byte(v>>16),
433-
byte(v>>24),
434-
byte(v>>32),
435-
byte(v>>40),
436-
byte(v>>48),
437-
byte(v>>56),
438-
)
439-
}

0 commit comments

Comments
 (0)