Skip to content

Commit 66d4add

Browse files
adonovangopherbot
authored andcommitted
internal/gocommand: re-disable flaky TestRmdirAfterGoList_Runner
The use of WaitDelay means completion of the Run operation does not mean the go command has terminated. Needs more thought. Updates golang/go#73736 Change-Id: Ia7852fc1cae13e841c0bc28f3567809e1b92915f Reviewed-on: https://go-review.googlesource.com/c/tools/+/675515 LUCI-TryBot-Result: Go LUCI <[email protected]> Auto-Submit: Alan Donovan <[email protected]> Reviewed-by: Jonathan Amsterdam <[email protected]>
1 parent ac05d44 commit 66d4add

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

internal/gocommand/invoke_test.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,8 @@ func TestGoVersion(t *testing.T) {
4141
// If this test ever fails, the combination of the gocommand package
4242
// and the go command itself has a bug; this has been observed (#73503).
4343
func TestRmdirAfterGoList_Runner(t *testing.T) {
44+
t.Skip("flaky; see https://github.com/golang/go/issues/73736#issuecomment-2885407104")
45+
4446
testRmdirAfterGoList(t, func(ctx context.Context, dir string) {
4547
var runner gocommand.Runner
4648
stdout, stderr, friendlyErr, err := runner.RunRaw(ctx, gocommand.Invocation{

0 commit comments

Comments
 (0)