Skip to content

Commit d91f7e6

Browse files
committed
runtime: fix GDB tests on s390x running Ubuntu 18.04
On Ubuntu 18.04 I am seeing GDB fail to restore the stack pointer during this test because stack unwinding can't find the PC. This CL is essentially a partial revert of CL 23940 and fixes the issue on s390x. Change-Id: Ib4c41162dc85dc882eb6e248330f4082c3fa94c3 Reviewed-on: https://go-review.googlesource.com/c/go/+/169857 Run-TryBot: Cherry Zhang <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Cherry Zhang <[email protected]>
1 parent aafe257 commit d91f7e6

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/runtime/runtime-gdb.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -540,8 +540,8 @@ def invoke(self, arg, _from_tty):
540540
# In GDB, assignments to sp must be done from the
541541
# top-most frame, so select frame 0 first.
542542
gdb.execute('select-frame 0')
543-
gdb.parse_and_eval('$sp = $save_sp')
544543
gdb.parse_and_eval('$pc = $save_pc')
544+
gdb.parse_and_eval('$sp = $save_sp')
545545
save_frame.select()
546546

547547

0 commit comments

Comments
 (0)