Skip to content

Commit 4f18477

Browse files
committed
math/big: implement subVW in riscv64 assembly
This provides an assembly implementation of subVW for riscv64, processing up to four words per loop, resulting in a significant performance gain. On a StarFive VisionFive 2: │ subvw.1 │ subvw.2 │ │ sec/op │ sec/op vs base │ SubVW/1-4 57.43n ± 0% 41.45n ± 0% -27.82% (p=0.000 n=10) SubVW/2-4 69.31n ± 0% 48.15n ± 0% -30.53% (p=0.000 n=10) SubVW/3-4 76.12n ± 0% 54.87n ± 0% -27.92% (p=0.000 n=10) SubVW/4-4 85.47n ± 0% 56.14n ± 0% -34.32% (p=0.000 n=10) SubVW/5-4 96.15n ± 0% 62.83n ± 0% -34.65% (p=0.000 n=10) SubVW/10-4 149.60n ± 0% 89.55n ± 0% -40.14% (p=0.000 n=10) SubVW/100-4 1115.0n ± 0% 549.3n ± 0% -50.74% (p=0.000 n=10) SubVW/1000-4 10.732µ ± 0% 5.071µ ± 0% -52.75% (p=0.000 n=10) SubVW/10000-4 153.0µ ± 0% 103.7µ ± 0% -32.21% (p=0.000 n=10) SubVW/100000-4 1.542m ± 0% 1.046m ± 0% -32.13% (p=0.000 n=10) SubVWext/1-4 57.42n ± 0% 41.45n ± 0% -27.81% (p=0.000 n=10) SubVWext/2-4 69.33n ± 0% 48.15n ± 0% -30.55% (p=0.000 n=10) SubVWext/3-4 76.12n ± 0% 54.93n ± 0% -27.84% (p=0.000 n=10) SubVWext/4-4 85.47n ± 0% 56.14n ± 0% -34.32% (p=0.000 n=10) SubVWext/5-4 96.15n ± 0% 62.83n ± 0% -34.65% (p=0.000 n=10) SubVWext/10-4 149.60n ± 0% 89.56n ± 0% -40.14% (p=0.000 n=10) SubVWext/100-4 1115.0n ± 0% 549.3n ± 0% -50.74% (p=0.000 n=10) SubVWext/1000-4 10.732µ ± 0% 5.061µ ± 0% -52.84% (p=0.000 n=10) SubVWext/10000-4 152.5µ ± 0% 103.7µ ± 0% -32.02% (p=0.000 n=10) SubVWext/100000-4 1.533m ± 0% 1.046m ± 0% -31.75% (p=0.000 n=10) geomean 1.005µ 633.7n -36.92% │ subvw.1 │ subvw.2 │ │ B/s │ B/s vs base │ SubVW/1-4 132.9Mi ± 0% 184.1Mi ± 0% +38.54% (p=0.000 n=10) SubVW/2-4 220.1Mi ± 0% 316.9Mi ± 0% +43.95% (p=0.000 n=10) SubVW/3-4 300.7Mi ± 0% 417.1Mi ± 0% +38.72% (p=0.000 n=10) SubVW/4-4 357.1Mi ± 0% 543.6Mi ± 0% +52.24% (p=0.000 n=10) SubVW/5-4 396.7Mi ± 0% 607.2Mi ± 0% +53.03% (p=0.000 n=10) SubVW/10-4 510.1Mi ± 0% 851.9Mi ± 0% +67.01% (p=0.000 n=10) SubVW/100-4 684.2Mi ± 0% 1388.9Mi ± 0% +102.99% (p=0.000 n=10) SubVW/1000-4 710.9Mi ± 0% 1504.5Mi ± 0% +111.63% (p=0.000 n=10) SubVW/10000-4 498.7Mi ± 0% 735.7Mi ± 0% +47.52% (p=0.000 n=10) SubVW/100000-4 494.8Mi ± 0% 729.1Mi ± 0% +47.34% (p=0.000 n=10) SubVWext/1-4 132.9Mi ± 0% 184.1Mi ± 0% +38.53% (p=0.000 n=10) SubVWext/2-4 220.1Mi ± 0% 316.9Mi ± 0% +44.00% (p=0.000 n=10) SubVWext/3-4 300.7Mi ± 0% 416.7Mi ± 0% +38.57% (p=0.000 n=10) SubVWext/4-4 357.1Mi ± 0% 543.6Mi ± 0% +52.24% (p=0.000 n=10) SubVWext/5-4 396.7Mi ± 0% 607.2Mi ± 0% +53.04% (p=0.000 n=10) SubVWext/10-4 510.1Mi ± 0% 851.9Mi ± 0% +67.01% (p=0.000 n=10) SubVWext/100-4 684.2Mi ± 0% 1388.9Mi ± 0% +102.99% (p=0.000 n=10) SubVWext/1000-4 710.9Mi ± 0% 1507.6Mi ± 0% +112.07% (p=0.000 n=10) SubVWext/10000-4 500.1Mi ± 0% 735.7Mi ± 0% +47.10% (p=0.000 n=10) SubVWext/100000-4 497.8Mi ± 0% 729.4Mi ± 0% +46.52% (p=0.000 n=10) geomean 387.6Mi 614.5Mi +58.51% Change-Id: I9d7fac719e977710ad9db9121fa298db6df605de Reviewed-on: https://go-review.googlesource.com/c/go/+/595398 Reviewed-by: Mark Ryan <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Meng Zhuo <[email protected]> Reviewed-by: Cherry Mui <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]>
1 parent c6f5698 commit 4f18477

File tree

1 file changed

+58
-1
lines changed

1 file changed

+58
-1
lines changed

src/math/big/arith_riscv64.s

Lines changed: 58 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -234,7 +234,64 @@ done:
234234
RET
235235

236236
TEXT ·subVW(SB),NOSPLIT,$0
237-
JMP ·subVW_g(SB)
237+
MOV x+24(FP), X5
238+
MOV y+48(FP), X6
239+
MOV z+0(FP), X7
240+
MOV z_len+8(FP), X30
241+
242+
MOV $4, X28
243+
MOV X6, X29 // b = y
244+
245+
BEQZ X30, done
246+
BLTU X30, X28, loop1
247+
248+
loop4:
249+
MOV 0(X5), X8 // x[0]
250+
MOV 8(X5), X11 // x[1]
251+
MOV 16(X5), X14 // x[2]
252+
MOV 24(X5), X17 // x[3]
253+
254+
SUB X29, X8, X10 // z[0] = x[0] - b
255+
SLTU X10, X8, X29 // next b
256+
257+
SUB X29, X11, X13 // z[1] = x[1] - b
258+
SLTU X13, X11, X29 // next b
259+
260+
SUB X29, X14, X16 // z[2] = x[2] - b
261+
SLTU X16, X14, X29 // next b
262+
263+
SUB X29, X17, X19 // z[3] = x[3] - b
264+
SLTU X19, X17, X29 // next b
265+
266+
MOV X10, 0(X7) // z[0]
267+
MOV X13, 8(X7) // z[1]
268+
MOV X16, 16(X7) // z[2]
269+
MOV X19, 24(X7) // z[3]
270+
271+
ADD $32, X5
272+
ADD $32, X7
273+
SUB $4, X30
274+
275+
BGEU X30, X28, loop4
276+
BEQZ X30, done
277+
278+
loop1:
279+
MOV 0(X5), X10 // x
280+
281+
SUB X29, X10, X12 // z = x - b
282+
SLTU X12, X10, X29 // next b
283+
284+
MOV X12, 0(X7) // z
285+
286+
ADD $8, X5
287+
ADD $8, X7
288+
SUB $1, X30
289+
290+
BNEZ X30, loop1
291+
292+
done:
293+
MOV X29, c+56(FP) // return b
294+
RET
238295

239296
TEXT ·shlVU(SB),NOSPLIT,$0
240297
JMP ·shlVU_g(SB)

0 commit comments

Comments
 (0)