#72. Fix crash on process.send using fail safe

Author: asilvas-godaddy

cluster-service.js

@@ -10,6 +10,7 @@ exports.debug = require("./lib/util").debug;
 exports.log = require("./lib/util").log;
 exports.error = require("./lib/util").error;
 exports.results = require("./lib/util").results;
+exports.processSafeSend = require("./lib/util").processSafeSend;
 exports.msgBus = require("./lib/message-bus");
 
 exports.workerReady = require("./lib/worker-ready");

lib/commands/workers.js

@@ -69,8 +69,12 @@ function getProcessDetails(worker) {
     }, 1000);
 
     worker.on("message", msgCb);
-    worker.process.send(cservice.msgBus.createMessage("processDetails"));
-    worker.process.send(cservice.msgBus.createMessage("netStats"));
+    cservice.processSafeSend(worker.process,
+        cservice.msgBus.createMessage("processDetails")
+    );
+    cservice.processSafeSend(worker.process,
+        cservice.msgBus.createMessage("netStats")
+    );
   };
 }
 

lib/message-bus.js

@@ -35,7 +35,8 @@ function sendMessage(cmd, options, filter, cb) {
 
   if (cluster.isWorker === true) {
     createWaiter(msg, process, cb);
-    return process.send(msg); // send to master and wait for response
+    // send to master and wait for response
+    return cservice.processSafeSend(process, msg);
   }
 
   var workers = cluster.workers;
@@ -76,7 +77,7 @@ function createWaiter(msg, process, cb) {
 function createWaiterTask(msg, process) {
   return function(asyncCb) {
     var waiter = createWaiter(msg, process, asyncCb);
-    process.send(msg);
+    cservice.processSafeSend(process, msg);
     if (!waiter) {
       // if no waiter, cb immediately
       asyncCb();
@@ -87,7 +88,7 @@ function createWaiterTask(msg, process) {
 function respondToMessage(msg, process, error, response) {
   msg.error = error;
   msg.response = response;
-  process.send(msg);
+  cservice.processSafeSend(process, msg);
 }
 
 function processMessage(msg) {

lib/net-stats.js

@@ -54,8 +54,9 @@ function monitor() {
 
     switch (msg.cservice.cmd) {
       case "netStats":
-        process.send(cservice.msgBus.createMessage("netStats", {
-          netStats: net
+        cservice.processSafeSend(process,
+          cservice.msgBus.createMessage("netStats", {
+            netStats: net
         }));
         break;
     }

lib/proxy-worker.js

@@ -136,5 +136,5 @@ function updateVersionLastAccess(version) {
   var msg = cservice.msgBus.createMessage("versionUpdateLastAccess", {
     version: version.name
   });
-  process.send(msg);
+  cservice.processSafeSend(process, msg);
 }

lib/util.js

@@ -12,6 +12,7 @@ exports.debug = debug;
 exports.log = log;
 exports.error = error;
 exports.results = results;
+exports.processSafeSend = processSafeSend;
 
 function debug() {
   var args;
@@ -201,3 +202,11 @@ function getArgFromValue(val) {
     return val; // use as-is
   }
 }
+
+function processSafeSend(process, msg) {
+  try {
+    process.send(msg);
+  } catch (ex) {
+    return ex;
+  }
+}

lib/worker-ready.js

@@ -34,7 +34,7 @@ function workerReady(options, forceIsWorker) {
   process.on("message", onMessageFromMaster);
 
   // allow worker to inform the master when ready to speed up initialization
-  process.send(
+  cservice.processSafeSend(process,
     messageBus.createMessage("workerReady", {
       onStop: (typeof options.onWorkerStop === "function")
     })

lib/workers.js

@@ -56,13 +56,14 @@ function monitor() {
 
     switch (msg.cservice.cmd) {
       case "processDetails":
-        process.send(cservice.msgBus.createMessage("processDetails", {
-          processDetails: {
-            memory: process.memoryUsage(),
-            title: process.title,
-            uptime: process.uptime(),
-            hrtime: process.hrtime()
-          }
+        cservice.processSafeSend(process,
+          cservice.msgBus.createMessage("processDetails", {
+            processDetails: {
+              memory: process.memoryUsage(),
+              title: process.title,
+              uptime: process.uptime(),
+              hrtime: process.hrtime()
+            }
         }));
         break;
     }

package.json

@@ -23,7 +23,6 @@
     "extend": ">=1.1.x"
   },
   "devDependencies": {
-    "6to5": "^3.6.5",
     "istanbul": "^0.3.13",
     "jshint": "^2.7.0",
     "mocha": "^2.2.4",