Skip to content

Commit e2ab6e4

Browse files
committed
Fix OpenAPI v2 to not merge service params into endpoint headers
1 parent 850363c commit e2ab6e4

File tree

1 file changed

+5
-23
lines changed

1 file changed

+5
-23
lines changed

http/codegen/openapi/v2/builder.go

+5-23
Original file line numberDiff line numberDiff line change
@@ -294,29 +294,11 @@ func paramsFromExpr(params *expr.MappedAttributeExpr, path string) []*Parameter
294294
func paramsFromHeaders(endpoint *expr.HTTPEndpointExpr) []*Parameter {
295295
var params []*Parameter
296296

297-
var (
298-
rma = endpoint.Service.Params
299-
ma = endpoint.Headers
300-
301-
merged *expr.MappedAttributeExpr
302-
)
303-
{
304-
if rma == nil {
305-
merged = ma
306-
} else if ma == nil {
307-
merged = rma
308-
} else {
309-
merged = expr.DupMappedAtt(rma)
310-
merged.Merge(ma)
311-
}
312-
}
313-
314-
for _, n := range *expr.AsObject(merged.Type) {
315-
header := n.Attribute
316-
required := merged.IsRequiredNoDefault(n.Name)
317-
p := paramFor(header, merged.ElemName(n.Name), "header", required)
318-
params = append(params, p)
319-
}
297+
expr.WalkMappedAttr(endpoint.Headers, func(name, elem string, att *expr.AttributeExpr) error { // nolint: errcheck
298+
required := endpoint.Headers.IsRequiredNoDefault(name)
299+
params = append(params, paramFor(att, elem, "header", required))
300+
return nil
301+
})
320302

321303
// Add basic auth to headers
322304
if att := expr.TaggedAttribute(endpoint.MethodExpr.Payload, "security:username"); att != "" {

0 commit comments

Comments
 (0)