Skip to content

Commit c567e6b

Browse files
committed
Handle Windows
1 parent d83b7ee commit c567e6b

File tree

4 files changed

+8
-15
lines changed

4 files changed

+8
-15
lines changed

codegen/example/example_server_test.go

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@ func init() {
2626
func compareOrUpdateGolden(t *testing.T, code, golden string) {
2727
t.Helper()
2828
if updateGolden {
29-
require.NoError(t, os.MkdirAll(filepath.Dir(golden), 0755))
30-
require.NoError(t, os.WriteFile(golden, []byte(code), 0644))
29+
require.NoError(t, os.MkdirAll(filepath.Dir(golden), 0750))
30+
require.NoError(t, os.WriteFile(golden, []byte(code), 0640))
3131
return
3232
}
3333
data, err := os.ReadFile(golden)
@@ -68,14 +68,7 @@ func TestExampleServerFiles(t *testing.T) {
6868
}
6969
code := codegen.FormatTestCode(t, "package foo\n"+buf.String())
7070
golden := filepath.Join("testdata", "server-"+c.Name+".golden")
71-
if updateGolden {
72-
require.NoError(t, os.MkdirAll(filepath.Dir(golden), 0755))
73-
require.NoError(t, os.WriteFile(golden, []byte(code), 0644))
74-
return
75-
}
76-
data, err := os.ReadFile(golden)
77-
require.NoError(t, err)
78-
assert.Equal(t, string(data), code)
71+
compareOrUpdateGolden(t, code, golden)
7972
})
8073
}
8174
}

grpc/codegen/example_server_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,8 @@ func init() {
2525
func compareOrUpdateGolden(t *testing.T, code, golden string) {
2626
t.Helper()
2727
if updateGolden {
28-
require.NoError(t, os.MkdirAll(filepath.Dir(golden), 0755))
29-
require.NoError(t, os.WriteFile(golden, []byte(code), 0644))
28+
require.NoError(t, os.MkdirAll(filepath.Dir(golden), 0750))
29+
require.NoError(t, os.WriteFile(golden, []byte(code), 0640))
3030
return
3131
}
3232
data, err := os.ReadFile(golden)

grpc/codegen/proto_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ func TestProtoFiles(t *testing.T) {
4747
if runtime.GOOS == "windows" {
4848
code = strings.ReplaceAll(code, "\r\n", "\n")
4949
}
50-
assert.Equal(t, code, c.Code)
50+
assert.Equal(t, c.Code, code)
5151
fpath := codegen.CreateTempFile(t, code)
5252
assert.NoError(t, protoc(fpath, nil), "error occurred when compiling proto file %q", fpath)
5353
})

http/codegen/example_server_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,8 @@ func init() {
2727
func compareOrUpdateGolden(t *testing.T, code, golden string) {
2828
t.Helper()
2929
if updateGolden {
30-
require.NoError(t, os.MkdirAll(filepath.Dir(golden), 0755))
31-
require.NoError(t, os.WriteFile(golden, []byte(code), 0644))
30+
require.NoError(t, os.MkdirAll(filepath.Dir(golden), 0750))
31+
require.NoError(t, os.WriteFile(golden, []byte(code), 0640))
3232
return
3333
}
3434
data, err := os.ReadFile(golden)

0 commit comments

Comments
 (0)