Add TooFewArgError to dsl.OneOf (#3577)

tchssk · raphael · web-flow · commit 7a9bc7ac1ab2 · 2024-08-13T21:25:50.000-07:00
Co-authored-by: Raphael Simon &lt;simon.raphael@gmail.com&gt;
diff --git a/dsl/attribute.go b/dsl/attribute.go
@@ -219,6 +219,10 @@ func Field(tag any, name string, args ...any) {
 //	    })
 //	})
 func OneOf(name string, args ...any) {
+	if len(args) == 0 {
+		eval.TooFewArgError()
+		return
+	}
 	if len(args) > 2 {
 		eval.TooManyArgError()
 		return
diff --git a/eval/eval_test.go b/eval/eval_test.go
@@ -42,6 +42,7 @@ func TestTooFewArgError(t *testing.T) {
 		"ErrorName":       func() { ErrorName() },
 		"ErrorName (int)": func() { Type("name", func() { ErrorName(1) }) },
 		"Example":         func() { Example() },
+		"OneOf":           func() { OneOf("name") },
 		"Response (grpc)": func() { Service("s", func() { GRPC(func() { Response("name") }) }) },
 		"Response (http)": func() { Service("s", func() { HTTP(func() { Response("name") }) }) },
 	}

Original file line number	Diff line number	Diff line change
`@@ -42,6 +42,7 @@ func TestTooFewArgError(t *testing.T) {`
`42`	`42`	`"ErrorName": func() { ErrorName() },`
`43`	`43`	`"ErrorName (int)": func() { Type("name", func() { ErrorName(1) }) },`
`44`	`44`	`"Example": func() { Example() },`
	`45`	`+ "OneOf": func() { OneOf("name") },`
`45`	`46`	`"Response (grpc)": func() { Service("s", func() { GRPC(func() { Response("name") }) }) },`
`46`	`47`	`"Response (http)": func() { Service("s", func() { HTTP(func() { Response("name") }) }) },`
`47`	`48`	`}`