Skip to content

Commit 86e698d

Browse files
committed
add rollback to get private profile when view as is not present
1 parent d71cba7 commit 86e698d

File tree

2 files changed

+24
-19
lines changed

2 files changed

+24
-19
lines changed

routers/web/org/home.go

Lines changed: 19 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -119,22 +119,30 @@ func home(ctx *context.Context, viewRepositories bool) {
119119
queryParams.Set("view_as", "public")
120120
ctx.Data["QueryForPublic"] = html_template.URL(queryParams.Encode())
121121

122-
isViewerMember := ctx.FormString("view_as") == "member"
123-
ctx.Data["IsViewerMember"] = isViewerMember
122+
err = shared_user.RenderOrgHeader(ctx)
123+
if err != nil {
124+
ctx.ServerError("RenderOrgHeader", err)
125+
return
126+
}
127+
128+
isViewerMember := ctx.FormString("view_as")
129+
ctx.Data["IsViewerMember"] = isViewerMember == "member"
124130

125131
profileType := "Public"
126-
if isViewerMember {
132+
if isViewerMember == "member" {
127133
profileType = "Private"
128134
}
129135

130-
if !prepareOrgProfileReadme(ctx, viewRepositories, profileType) {
131-
ctx.Data["PageIsViewRepositories"] = true
132-
}
133-
134-
err = shared_user.RenderOrgHeader(ctx)
135-
if err != nil {
136-
ctx.ServerError("RenderOrgHeader", err)
137-
return
136+
if isViewerMember == "" {
137+
if !prepareOrgProfileReadme(ctx, viewRepositories, "Public") {
138+
if !prepareOrgProfileReadme(ctx, viewRepositories, "Private") {
139+
ctx.Data["PageIsViewRepositories"] = true
140+
}
141+
}
142+
} else {
143+
if !prepareOrgProfileReadme(ctx, viewRepositories, profileType) {
144+
ctx.Data["PageIsViewRepositories"] = true
145+
}
138146
}
139147

140148
var (

templates/org/home.tmpl

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -19,14 +19,11 @@
1919
</div>
2020
{{end}}
2121
{{end}}
22-
{{if .IsViewerMember}}
23-
{{if and .ShowMemberAndTeamTab .PrivateProfileReadme}}
24-
<div id="readme_profile" class="markup">{{.PrivateProfileReadme}}</div>
25-
{{end}}
26-
{{else}}
27-
{{if .PublicProfileReadme}}
28-
<div id="readme_profile" class="markup">{{.PublicProfileReadme}}</div>
29-
{{end}}
22+
{{if .PrivateProfileReadme}}
23+
<div id="readme_profile" class="markup">{{.PrivateProfileReadme}}</div>
24+
{{end}}
25+
{{if .PublicProfileReadme}}
26+
<div id="readme_profile" class="markup">{{.PublicProfileReadme}}</div>
3027
{{end}}
3128
{{template "shared/repo_search" .}}
3229
{{template "explore/repo_list" .}}

0 commit comments

Comments
 (0)