Merge pull request #50 from whickman/wh/handle-bad-file-path

Handle filenames with leading periods correctly

Author: mcuadros

helper/chroot/chroot.go

@@ -37,7 +37,7 @@ func isCrossBoundaries(path string) bool {
 	path = filepath.ToSlash(path)
 	path = filepath.Clean(path)
 
-	return strings.HasPrefix(path, "..")
+	return strings.HasPrefix(path, ".."+string(filepath.Separator))
 }
 
 func (fs *ChrootHelper) Create(filename string) (billy.File, error) {

helper/chroot/chroot_test.go

@@ -37,6 +37,15 @@ func (s *ChrootSuite) TestCreateErrCrossedBoundary(c *C) {
 	c.Assert(err, Equals, billy.ErrCrossedBoundary)
 }
 
+func (s *ChrootSuite) TestLeadingPeriodsPathNotCrossedBoundary(c *C) {
+	m := &test.BasicMock{}
+
+	fs := New(m, "/foo")
+	f, err := fs.Create("..foo")
+	c.Assert(err, IsNil)
+	c.Assert(f.Name(), Equals, "..foo")
+}
+
 func (s *ChrootSuite) TestOpen(c *C) {
 	m := &test.BasicMock{}