Skip to content

I think we have a problem in the way the tests are called in the testsuite #2036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alaingdl opened this issue May 14, 2025 · 1 comment
Open

Comments

@alaingdl
Copy link
Contributor

Last time, I mentioned in #2026 that the problem inside TEST_READF was not visibly detected by the automatic run of make check. I have another case with TEST_LABEL_DATE (in fact, LABEL_DATE uses the old () syntax for array index and need a cleanup, but another story and the next bug report ;)

I don't want to add a Catch mechanism inside every test ! Should we add a ON_ERROR, 2 ??

If we look at Testing/Temporary/LastTest.log we just have :

----------------------------------------------------------
% Compiled module: TEST_LABEL_DATE.
% Warning: Assignment to loop variable detected.
% Warning: Assignment to loop variable detected.
% LABEL_DATE: Function not found: DEFDOW
<end of output>

but in fact TEST_LABEL_DATE was not processed ! Just stopped inside ! (I don't understand why EXECUTE() considers that as a success ;)

Without ON_ERROR, 2

/home/alain/GDL/gdl-1.1.2git250514CMake/build_cmake/src/gdl -quiet -e "print, execute('test_label_date')"
% Compiled module: TEST_LABEL_DATE.
% Warning: Assignment to loop variable detected.
% Warning: Assignment to loop variable detected.
% LABEL_DATE: Function not found: DEFDOW
       1

If I add a ON_ERROR, 2 the result is 0

The problem when I use the script nothing is visible (should be in the testsuite)
(/home/alain/GDL/gdl-1.1.2git250514CMake/build_cmake/src/gdl -quiet -e "if execute('test_linfit') ne 1 then exit, status=1" )

@alaingdl
Copy link
Contributor Author

I forgot to mention : in fact everything is in the logs in Testing/Temporary/ but I am quite sure nobody gave an eye here since a while ! And with the current way no obvious pattern will be visible. One need to read carefully every line !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant