bugfixes

Author: glevv

src/obscure_stats/association/association.py

@@ -39,7 +39,7 @@ def _check_arrays(x: np.ndarray, y: np.ndarray) -> bool:
             stacklevel=2,
         )
         return True
-    if (np.isnan(_x).sum() >= len(_x) - 1) or (np.isnan(_y).sum() >= len(_x) - 1):
+    if (np.isnan(_x).sum() >= len(_x) - 1) or (np.isnan(_y).sum() >= len(_y) - 1):
         warnings.warn(
             "One of the input arrays has too many missing values,"
             " please check the arrays.",
@@ -599,5 +599,5 @@ def quantile_correlation(x: np.ndarray, y: np.ndarray, q: float = 0.5) -> float:
     x, y = _prep_arrays(x, y)
     return (
         np.mean(q - (y - np.quantile(y, q=q) < 0) * (x - np.mean(x)))
-        / ((q * q**2) * np.var(x)) ** 0.5
+        / ((q - q**2) * np.var(x)) ** 0.5
     )

tests/test_association.py

@@ -193,6 +193,6 @@ def test_corr_boundaries(func: typing.Callable, y_array_float: np.ndarray) -> No
     ),
 )
 @pytest.mark.parametrize("func", all_functions)
-def test_fuzz_all(func: typing.Callable, x: np.ndarray, y: np.ndarray) -> None:
+def test_fuzz_associations(func: typing.Callable, x: np.ndarray, y: np.ndarray) -> None:
     """Test all functions with fuzz."""
     func(x, y)

tests/test_central_tendency.py

@@ -66,6 +66,10 @@ def test_edge_cases(x_array_float: np.ndarray) -> None:
     if result != pytest.approx(x_array_float[0], rel=1e-4):
         msg = "Result does not match expected output."
         raise ValueError(msg)
+    result = standard_trimmed_harrell_davis_quantile([])
+    if result is not np.nan:
+        msg = "Result does not match expected output."
+        raise ValueError(msg)
 
 
 def test_q_in_sthdq(x_array_float: np.ndarray) -> None:
@@ -124,6 +128,6 @@ def test_statistic_with_nans(func: typing.Callable, x_array_nan: np.ndarray) ->
     )
 )
 @pytest.mark.parametrize("func", all_functions)
-def test_fuzz_all(func: typing.Callable, data: np.ndarray) -> None:
+def test_fuzz_central_tendencies(func: typing.Callable, data: np.ndarray) -> None:
     """Test all functions with fuzz."""
     func(data)

tests/test_dispersion.py

@@ -101,6 +101,6 @@ def test_statistic_with_nans(func: typing.Callable, x_array_nan: np.ndarray) ->
     )
 )
 @pytest.mark.parametrize("func", all_functions)
-def test_fuzz_all(func: typing.Callable, data: np.ndarray) -> None:
+def test_fuzz_dispersions(func: typing.Callable, data: np.ndarray) -> None:
     """Test all functions with fuzz."""
     func(data)

tests/test_kurtosis.py

@@ -70,6 +70,6 @@ def test_statistic_with_nans(func: typing.Callable, x_array_nan: np.ndarray) ->
     )
 )
 @pytest.mark.parametrize("func", all_functions)
-def test_fuzz_all(func: typing.Callable, data: np.ndarray) -> None:
+def test_fuzz_kurtosises(func: typing.Callable, data: np.ndarray) -> None:
     """Test all functions with fuzz."""
     func(data)

tests/test_skewness.py

@@ -94,6 +94,6 @@ def test_statistic_with_nans(func: typing.Callable, x_array_nan: np.ndarray) ->
     )
 )
 @pytest.mark.parametrize("func", all_functions)
-def test_fuzz_all(func: typing.Callable, data: np.ndarray) -> None:
+def test_fuzz_skewnesses(func: typing.Callable, data: np.ndarray) -> None:
     """Test all functions with fuzz."""
     func(data)

tests/test_variation.py

@@ -86,6 +86,6 @@ def test_renyi_entropy_edgecases(c_array_obj: np.ndarray) -> None:
     )
 )
 @pytest.mark.parametrize("func", all_functions)
-def test_fuzz_all(func: typing.Callable, data: np.ndarray) -> None:
+def test_fuzz_variations(func: typing.Callable, data: np.ndarray) -> None:
     """Test all functions with fuzz."""
     func(data)