Re-implement old features #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

joewandy opened this issue Jan 31, 2023 · 0 comments

Labels

Member

joewandy commented Jan 31, 2023 •

edited

Loading

After code-refactoring, the following features are no longer supported in the simulated mass spec. They should be re-implemented at some point:

Being able to define multiple isolation windows for one MS2 scan, see here. Also some unit tests for this have been commented out, make sure to uncomment them.
Functional chromatograms only support Gaussian shapes, not gamma or uniform as before, see here.

joewandy added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment