Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commit amend directly in log tab #778

Closed
parrotdance opened this issue Jun 8, 2021 · 3 comments · Fixed by #779
Closed

commit amend directly in log tab #778

parrotdance opened this issue Jun 8, 2021 · 3 comments · Fixed by #779
Labels
bug Something isn't working
Milestone

Comments

@parrotdance
Copy link

Is your feature request related to a problem? Please describe.

I always type the command git commit --amend directly, instead type git commit first and considered about "should I add --amend flag?". So I think provide "Commit amend" right in status panel (but not in popup panel) will be a nice improvement(at least for me).

Describe the solution you'd like

Provide "commit with amend" command right in status panel.

Describe alternatives you've considered

btw, there is nothing about "how to make a amend commit" in the help panel, I find the right way but still spend some time to search issues and PRs.

@extrawurst
Copy link
Collaborator

I agree with the second part, it is a bug that the instructions for finding amend are not in help this will be addressed. but putting more commands on the top level is not the solution IMO

@extrawurst extrawurst added the bug Something isn't working label Jun 8, 2021
@extrawurst extrawurst added this to the v0.17 milestone Jun 8, 2021
@extrawurst
Copy link
Collaborator

this is what it is supposed to look like after merging #779

Screenshot 2021-06-08 at 11 26 40

@abergmeier
Copy link

This is especially bad as commit currently is submitted via ENTER.
The numbers I have accidentally submitted a commit is legion.

In all these cases I just want to fix the recent commit - but often cannot because I have no other changes to trigger the commit dialog.

If this really is not possible for default - maybe we could add an extension mechanism for adding commands to screens?
So maybe an yaml file where you write:

screens:
  status:
    add_commands:
     - amend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants