-
-
Notifications
You must be signed in to change notification settings - Fork 605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
more error handling #53
Comments
Hi, I would love to help but I don't have much experience in Rust. Can I take this issue ? |
Hy @MCord thanks for your interest in helping❤️! Absolutely you can grab this one - let me know when you need any input! |
So here is my first question: do we want to define a custom error for |
Good question. I was expecting to have to come up with a lib specific Error using thiserror and wrapping |
Ok, let's try that. I will send a PR so we can discuss the implementation. |
Really cool! Thank you❤️! |
I have created a pull request #58. I will continue when you give me some feedback. |
I started
asyncgit
crate ignoring errorsunwrap
is all over the place but the goal would be to handle them correctly like withsync::get_commits_info
The text was updated successfully, but these errors were encountered: