[VTAdmin] Cherry Pick Topology Browser (vitessio#11518)

* Add web side of topology components

Signed-off-by: notfelineit <[email protected]>

* Add GetTopologyPath

Signed-off-by: notfelineit <[email protected]>

* Add protos

Signed-off-by: notfelineit <[email protected]>

* Add comment explaining why name is not needed at toplevel topo path

Signed-off-by: notfelineit <[email protected]>

* Add GetTopologyPath to vtadmin

Signed-off-by: notfelineit <[email protected]>

* Modify node code for non recursive

Signed-off-by: notfelineit <[email protected]>

* Update logic for GetTopologyPath

Signed-off-by: notfelineit <[email protected]>

* Render correct depth for nodes

Signed-off-by: notfelineit <[email protected]>

* Add tests TestGetTopologyPath

Signed-off-by: notfelineit <[email protected]>

* Add GetTopologyPath command

Signed-off-by: notfelineit <[email protected]>

* Run lint prettier fix

Signed-off-by: notfelineit <[email protected]>

* Consolidate DecodeContent to vt/topo package - can't put in vt/topo/topoproto because of import cycle

Signed-off-by: notfelineit <[email protected]>

* Add rbac check for TopologyResource

Signed-off-by: notfelineit <[email protected]>

* Update DecodeContent of zkcmd.go

Signed-off-by: notfelineit <[email protected]>

* Update help text

Signed-off-by: notfelineit <[email protected]>

* Run make proto again

Signed-off-by: notfelineit <[email protected]>

* Run lint prettier fix

Signed-off-by: notfelineit <[email protected]>

Signed-off-by: notfelineit <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
Co-authored-by: Florent Poinsard <[email protected]>

Author: notfelineit

go/cmd/vtctldclient/command/topology.go

@@ -0,0 +1,64 @@
+/*
+Copyright 2022 The Vitess Authors.
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+	http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package command
+
+import (
+	"fmt"
+
+	"github.com/spf13/cobra"
+
+	"vitess.io/vitess/go/cmd/vtctldclient/cli"
+
+	vtctldatapb "vitess.io/vitess/go/vt/proto/vtctldata"
+)
+
+var (
+	// GetTopologyPath makes a GetTopologyPath gRPC call to a vtctld.
+	GetTopologyPath = &cobra.Command{
+		Use:                   "GetTopologyPath <path>",
+		Short:                 "Gets the file located at the specified path in the topology server.",
+		DisableFlagsInUseLine: true,
+		Args:                  cobra.ExactArgs(1),
+		RunE:                  commandGetTopologyPath,
+	}
+)
+
+func commandGetTopologyPath(cmd *cobra.Command, args []string) error {
+	path := cmd.Flags().Arg(0)
+
+	cli.FinishedParsing(cmd)
+
+	resp, err := client.GetTopologyPath(commandCtx, &vtctldatapb.GetTopologyPathRequest{
+		Path: path,
+	})
+	if err != nil {
+		return err
+	}
+
+	data, err := cli.MarshalJSON(resp.Cell)
+	if err != nil {
+		return err
+	}
+
+	fmt.Printf("%s\n", data)
+
+	return nil
+}
+
+func init() {
+	Root.AddCommand(GetTopologyPath)
+}

go/cmd/zk/zkcmd.go

@@ -40,8 +40,8 @@ import (
 	"vitess.io/vitess/go/exit"
 	"vitess.io/vitess/go/vt/log"
 	"vitess.io/vitess/go/vt/logutil"
+	"vitess.io/vitess/go/vt/topo"
 	"vitess.io/vitess/go/vt/topo/zk2topo"
-	"vitess.io/vitess/go/vt/vtctl"
 )
 
 var doc = `
@@ -588,7 +588,7 @@ func cmdCat(ctx context.Context, subFlags *pflag.FlagSet, args []string) error {
 		}
 		decoded := ""
 		if decodeProto {
-			decoded, err = vtctl.DecodeContent(zkPath, data, false)
+			decoded, err = topo.DecodeContent(zkPath, data, false)
 			if err != nil {
 				log.Warningf("cat: cannot proto decode %v: %v", zkPath, err)
 				decoded = string(data)

go/flags/endtoend/vtctldclient.txt

@@ -45,6 +45,7 @@ Available Commands:
   GetTablet                   Outputs a JSON structure that contains information about the tablet.
   GetTabletVersion            Print the version of a tablet from its debug vars.
   GetTablets                  Looks up tablets according to filter criteria.
+  GetTopologyPath             Gets the file located at the specified path in the topology server.
   GetVSchema                  Prints a JSON representation of a keyspace's topo record.
   GetWorkflows                Gets all vreplication workflows (Reshard, MoveTables, etc) in the given keyspace.
   InitShardPrimary            Sets the initial primary for the shard.