You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
* Move vtorc from go-sqlite3 to modernc.org/sqlite (vitessio#12214)
* Move vtorc from go-sqlite3 to modernc.org/sqlite
This moves vtorc from the go-sqlite3 library that uses CGO, to use
modernc.org/sqlite which is a pure Go implementation.
vtorc is the only component we have to build with CGO but it's causing
pain for releases since we need to build it against an old Linux for
linking against glibc.
Using modernc.org/sqlite allows for using Go only again and makes all
Vitess components buildable without CGO.
In
https://datastation.multiprocess.io/blog/2022-05-12-sqlite-in-go-with-and-without-cgo.html
someone ran some basic benchmarks. It shows that the pure Go version can
be twice as slow, but the usage of vtorc is very limited and we operate
on small datasets, so I think the performance impact purely of a
somewhat slower sqlite implementation is negligable.
None of this is in a hot query serving path or anything like that, so I
have little concern performance wise.
Signed-off-by: Dirkjan Bussink <[email protected]>
* Fix error handling in RowToArray
Signed-off-by: Dirkjan Bussink <[email protected]>
---------
Signed-off-by: Dirkjan Bussink <[email protected]>
* empty-commit
Signed-off-by: Manan Gupta <[email protected]>
* Run go mod tidy
Signed-off-by: Dirkjan Bussink <[email protected]>
---------
Signed-off-by: Dirkjan Bussink <[email protected]>
Signed-off-by: Manan Gupta <[email protected]>
Co-authored-by: Manan Gupta <[email protected]>
Copy file name to clipboardExpand all lines: go/vt/vtgr/config/vtgr_config.go
+3-3
Original file line number
Diff line number
Diff line change
@@ -104,8 +104,8 @@ type Configuration struct {
104
104
MySQLTopologyUseMutualTLSbool// Turn on TLS authentication with the Topology MySQL instances
105
105
MySQLTopologyUseMixedTLSbool// Mixed TLS and non-TLS authentication with the Topology MySQL instances
106
106
TLSCacheTTLFactoruint// Factor of InstancePollSeconds that we set as TLS info cache expiry
107
-
BackendDBstring// EXPERIMENTAL: type of backend db; either "mysql" or "sqlite3"
108
-
SQLite3DataFilestring// when BackendDB == "sqlite3", full path to sqlite3 datafile
107
+
BackendDBstring// EXPERIMENTAL: type of backend db; either "mysql" or "sqlite"
108
+
SQLite3DataFilestring// when BackendDB == "sqlite", full path to sqlite3 datafile
109
109
SkipOrchestratorDatabaseUpdatebool// When true, do not check backend database schema nor attempt to update it. Useful when you may be running multiple versions of orchestrator, and you only wish certain boxes to dictate the db structure (or else any time a different orchestrator version runs it will rebuild database schema)
110
110
PanicIfDifferentDatabaseDeploybool// When true, and this process finds the orchestrator backend DB was provisioned by a different version, panic
111
111
RaftEnabledbool// When true, setup orchestrator in a raft consensus layout. When false (default) all Raft* variables are ignored
0 commit comments