Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create_pull_request_review tool does not support inline comments with line parameter #112

Closed
ashwin-ant opened this issue Apr 5, 2025 · 0 comments · Fixed by #118
Closed
Labels
bug Something isn't working

Comments

@ashwin-ant
Copy link
Contributor

Describe the bug

When an inline comment is specified for the create_pull_request_review tool, it currently only allows comments with the position field specified. The GitHub REST API endpoint for creating pull requests supports line as an alternative to position. Would it be possible to support this option in the MCP tool?

Affected version

server version v0.1.0 (b89336793c5bc9b9abdd5100d876babbc1031f5d) 2025-04-04T15:38:21Z

Steps to reproduce the behavior

Try posting a pull request with a comments field like:

comments: [
  {
    path: 'file.md',
    line: 6,
    body: 'body text here'
  }
]

Expected vs actual behavior

Expected: Review posts with an inline comment on line 6 of file.md

Actual: tool call fails with error each comment must have a position

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant