dont reuse client because we change the timeout

Author: timvaillancourt

pkg/throttle/throttler.go

@@ -322,7 +322,7 @@ func (throttler *Throttler) refreshMySQLInventory() error {
 
 			if !clusterSettings.VitessSettings.IsEmpty() {
 				if throttler.vitessClient == nil {
-					throttler.vitessClient = vitess.New(throttler.httpClient)
+					throttler.vitessClient = vitess.New()
 				}
 				log.Debugf("getting vitess data from %s", clusterSettings.VitessSettings.API)
 				keyspace := clusterSettings.VitessSettings.Keyspace

pkg/vitess/api_client.go

@@ -8,6 +8,7 @@ import (
 	"strings"
 	"time"
 
+	"github.com/github/freno/pkg/base"
 	"vitess.io/vitess/go/vt/proto/topodata"
 )
 
@@ -51,8 +52,8 @@ type Client struct {
 }
 
 // New returns a new Client
-func New(client *http.Client) *Client {
-	return &Client{client: client}
+func New() *Client {
+	return &Client{client: base.SetupHttpClient(0)}
 }
 
 // ParseTablets reads from vitess /api/ks_tablets/<keyspace>/[shard] and returns a

pkg/vitess/api_client_test.go

@@ -50,7 +50,7 @@ func TestParseTablets(t *testing.T) {
 	}))
 	defer vitessApi.Close()
 
-	vtClient := New(&http.Client{})
+	vtClient := New()
 
 	t.Run("success", func(t *testing.T) {
 		tablets, err := vtClient.ParseTablets(vitessApi.URL, "test", "00", 1)