Merge pull request #92 from github/remove-react

Remove react config

Author: koddsson

bin/eslint-github-init.js

@@ -7,9 +7,7 @@ const path = require('path')
 const defaults = {
   project: 'lib',
   env: 'browser',
-  typeSystem: 'none',
-  react: true,
-  relay: true
+  typeSystem: 'none'
 }
 
 const packagePath = path.resolve(process.cwd(), 'package.json')
@@ -20,9 +18,6 @@ if (fs.existsSync(packagePath)) {
   const dependencies = Object.keys(packageJSON.dependencies || {})
   const devDependencies = Object.keys(packageJSON.devDependencies || {})
 
-  defaults.react = dependencies.includes('react') || devDependencies.includes('react')
-  defaults.relay = dependencies.includes('relay') || devDependencies.includes('relay')
-
   if (dependencies.includes('flow-bin') || devDependencies.includes('flow-bin')) {
     defaults.typeSystem = 'flow'
   }
@@ -52,19 +47,6 @@ const questions = [
     message: 'What type system are you using?',
     choices: ['flow', 'typescript', 'none'],
     default: defaults.typeSystem
-  },
-  {
-    type: 'confirm',
-    name: 'relay',
-    message: 'Are you using Relay?',
-    default: defaults.relay
-  },
-  {
-    type: 'confirm',
-    name: 'react',
-    message: 'Are you using React?',
-    default: defaults.react,
-    when: answers => answers.env === 'browser'
   }
 ]
 
@@ -96,16 +78,10 @@ inquirer.prompt(questions).then(answers => {
           moduleResolution: 'node'
         }
       }
-      if (answers.react) {
-        tsconfigDefaults.compilerOptions.jsx = 'react'
-      }
       fs.writeFileSync(tsconfigPath, JSON.stringify(tsconfigDefaults, null, '  '), 'utf8')
     }
   }
 
-  if (answers.react) eslintrc.extends.push('plugin:github/react')
-  if (answers.relay) eslintrc.extends.push('plugin:github/relay')
-
   fs.writeFileSync(path.resolve(process.cwd(), '.eslintrc.json'), JSON.stringify(eslintrc, null, '  '), 'utf8')
 
   const prettierConfig = []

docs/configs.md

@@ -30,14 +30,6 @@ Recommended rules when using Babel to transpile features from ES2015+.
 
 Recommended rules for projects using the [Flow type checker](https://flow.org/).
 
-### `plugin:github/react`
-
-Recommended rules for projects using [React](https://reactjs.org/).
-
-### `plugin:github/relay`
-
-Recommended rules for projects using [Relay](http://facebook.github.io/relay/) (and React).
-
 ### `plugin:github/app`
 
 Recommended rules when writing a browser application.

lib/configs/react.js

@@ -26,9 +26,7 @@ module.exports = {
     es6: require('./configs/es6'),
     flow: require('./configs/flow'),
     node: require('./configs/node'),
-    react: require('./configs/react'),
     recommended: require('./configs/recommended'),
-    relay: require('./configs/relay'),
     typescript: require('./configs/typescript')
   }
 }