Skip to content

Commit b09f3c1

Browse files
committed
Don't build with cross any longer.
We've removed cross from the internal build when converting to bazel, mirror that here.
1 parent 8c46b61 commit b09f3c1

File tree

2 files changed

+3
-14
lines changed

2 files changed

+3
-14
lines changed

ruby/actions/create-extractor-pack/action.yml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,12 @@ runs:
77
id: os_version
88
- name: Cache entire extractor
99
id: cache-extractor
10-
uses: actions/cache@v3
10+
uses: actions/cache@v4
1111
with:
1212
path: ruby/extractor-pack
1313
key: ${{ runner.os }}-${{ steps.os_version.outputs.version }}-extractor-${{ hashFiles('ruby/extractor/rust-toolchain.toml', 'ruby/scripts/create-extractor-pack.sh', 'ruby/extractor/**/Cargo.lock', 'ruby/actions/create-extractor-pack/action.yml') }}-${{ hashFiles('shared/tree-sitter-extractor') }}-${{ hashFiles('ruby/extractor/**/*.rs') }}-${{ hashFiles('ruby/codeql-extractor.yml', 'ruby/downgrades', 'ruby/tools', 'ruby/ql/lib/ruby.dbscheme', 'ruby/ql/lib/ruby.dbscheme.stats') }}
1414
- name: Cache cargo
15-
uses: actions/cache@v3
15+
uses: actions/cache@v4
1616
if: steps.cache-extractor.outputs.cache-hit != 'true'
1717
with:
1818
path: |
@@ -24,6 +24,5 @@ runs:
2424
if: steps.cache-extractor.outputs.cache-hit != 'true'
2525
shell: bash
2626
run: |
27-
cargo install cross --version 0.2.5
2827
scripts/create-extractor-pack.sh
2928
working-directory: ruby

ruby/scripts/create-extractor-pack.sh

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,27 +1,17 @@
11
#!/bin/bash
22
set -eux
3-
CARGO=cargo
43
if [[ "$OSTYPE" == "linux-gnu"* ]]; then
54
platform="linux64"
6-
if which cross; then
7-
CARGO=cross
8-
fi
95
elif [[ "$OSTYPE" == "darwin"* ]]; then
106
platform="osx64"
117
else
128
echo "Unknown OS"
139
exit 1
1410
fi
1511

16-
(cd extractor && "$CARGO" build --release)
12+
(cd extractor && cargo build --release)
1713

18-
# If building via cross, the binaries will be in extractor/target/<triple>/release
19-
# If building via cargo, the binaries will be in extractor/target/release
2014
BIN_DIR=extractor/target/release
21-
if [[ "$CARGO" == "cross" ]]; then
22-
BIN_DIR=extractor/target/x86_64-unknown-linux-gnu/release
23-
fi
24-
2515
"$BIN_DIR/codeql-extractor-ruby" generate --dbscheme ql/lib/ruby.dbscheme --library ql/lib/codeql/ruby/ast/internal/TreeSitter.qll
2616

2717
codeql query format -i ql/lib/codeql/ruby/ast/internal/TreeSitter.qll

0 commit comments

Comments
 (0)