Skip to content

Commit ad75906

Browse files
geoffw0hvitved
andauthored
Apply suggestions from code review
Co-authored-by: Tom Hvitved <[email protected]>
1 parent 4b93325 commit ad75906

File tree

2 files changed

+2
-10
lines changed

2 files changed

+2
-10
lines changed

rust/ql/lib/codeql/rust/Concepts.qll

+1-9
Original file line numberDiff line numberDiff line change
@@ -179,15 +179,7 @@ module SqlSanitization {
179179
module Cryptography {
180180
private import codeql.rust.internal.ConceptsShared::Cryptography as SC
181181

182-
/**
183-
* A data-flow node that is an application of a cryptographic algorithm. For example,
184-
* encryption, decryption, signature-validation.
185-
*
186-
* Extend this class to refine existing API models. If you want to model new APIs,
187-
* extend `CryptographicOperation::Range` instead.
188-
*/
189-
class CryptographicOperation extends SC::CryptographicOperation instanceof CryptographicOperation::Range
190-
{ }
182+
final class CryptographicOperation = SC:: CryptographicOperation;
191183

192184
class EncryptionAlgorithm = SC::EncryptionAlgorithm;
193185

rust/ql/lib/codeql/rust/frameworks/RustCrypto.qll

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ private string simplifyAlgorithmName(string algorithmName) {
1616
* An operation that initializes a cipher through the `cipher::KeyInit` or
1717
* `cipher::KeyIvInit` trait, for example `Des::new` or `cbc::Encryptor<des::Des>::new`.
1818
*/
19-
class StreamCipherInit extends Cryptography::CryptographicOperation::Range, DataFlow::Node {
19+
class StreamCipherInit extends Cryptography::CryptographicOperation::Range {
2020
string algorithmName;
2121

2222
StreamCipherInit() {

0 commit comments

Comments
 (0)