Skip to content

Commit 8bdd10c

Browse files
committed
C++: Fix spurious columns in 'CRegKey'.
1 parent 5f33733 commit 8bdd10c

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

cpp/ql/lib/ext/CRegKey.model.yml

+3-3
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,6 @@ extensions:
1515
- ["", "CRegKey", True, "QueryValue", "(LPCTSTR,DWORD *,void *,ULONG *)", "", "Argument[*0]", "Argument[*2]", "taint", "manual"]
1616
- ["", "CRegKey", True, "QueryValue", "(DWORD &,LPCTSTR)", "", "Argument[*1]", "Argument[*0]", "taint", "manual"]
1717
- ["", "CRegKey", True, "QueryValue", "(LPTSTR,LPCTSTR,DWORD *)", "", "Argument[*1]", "Argument[*0]", "taint", "manual"]
18-
- ["", "CRegKey", True, "QueryValue", "operator HKEY", "", "Argument[-1]", "ReturnValue", "taint", "manual"]
19-
- ["", "CRegKey", True, "QueryValue", "operator=", "", "Argument[*0]", "ReturnValue[*]", "value", "manual"]
20-
- ["", "CRegKey", True, "QueryValue", "operator=", "", "Argument[*0]", "Argument[-1]", "value", "manual"]
18+
- ["", "CRegKey", True, "operator HKEY", "", "", "Argument[-1]", "ReturnValue", "taint", "manual"]
19+
- ["", "CRegKey", True, "operator=", "", "", "Argument[*0]", "ReturnValue[*]", "value", "manual"]
20+
- ["", "CRegKey", True, "operator=", "", "", "Argument[*0]", "Argument[-1]", "value", "manual"]

cpp/ql/test/library-tests/dataflow/external-models/validatemodels.expected

+1-2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
| Dubious member name "operator BSTR" in summary model. |
2+
| Dubious member name "operator HKEY" in summary model. |
23
| Dubious member name "operator LPCSTR" in summary model. |
34
| Dubious member name "operator LPSAFEARRAY" in summary model. |
45
| Dubious member name "operator LPSTR" in summary model. |
@@ -44,5 +45,3 @@
4445
| Dubious signature "(size_type,const T &,const Allocator &)" in summary model. |
4546
| Dubious signature "(vector &&)" in summary model. |
4647
| Dubious signature "(vector &&,const Allocator &)" in summary model. |
47-
| Dubious signature "operator HKEY" in summary model. |
48-
| Dubious signature "operator=" in summary model. |

0 commit comments

Comments
 (0)