Skip to content

Commit 23d552e

Browse files
committed
Data flow: Move FlowThrough module into TypeTrackingInput
1 parent 26b46e7 commit 23d552e

File tree

4 files changed

+566
-572
lines changed

4 files changed

+566
-572
lines changed

cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/DataFlowPrivate.qll

+1-1
Original file line numberDiff line numberDiff line change
@@ -1434,7 +1434,7 @@ private predicate localFlowStepWithSummaries(Node node1, Node node2) {
14341434
or
14351435
readStep(node1, _, node2)
14361436
or
1437-
DataFlowImplCommon::argumentValueFlowsThrough(node1, _, node2, _)
1437+
DataFlowImplCommon::argumentValueFlowsThroughExposedForCppOnly(node1, _, node2, _)
14381438
}
14391439

14401440
/** Holds if `node` flows to a node that is used in a `SwitchInstruction`. */
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
11
| A.java:5:12:5:15 | this | A.java:5:12:5:19 | this.foo | A.java:2:7:2:9 | foo |
2-
| A.java:21:13:21:13 | a | A.java:21:13:21:22 | getFoo(...) | A.java:2:7:2:9 | foo |
3-
| A.java:23:9:23:9 | a | A.java:23:9:23:19 | aGetter(...) | A.java:2:7:2:9 | foo |
42
| A.java:45:12:45:38 | maybeIdWrap(...) | A.java:45:12:45:42 | maybeIdWrap(...).foo | A.java:2:7:2:9 | foo |
53
| A.java:49:12:49:38 | maybeIdWrap(...) | A.java:49:12:49:42 | maybeIdWrap(...).foo | A.java:2:7:2:9 | foo |

java/ql/test/library-tests/dataflow/getter/getter.ql

+1-4
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,6 @@ import semmle.code.java.dataflow.internal.DataFlowImplSpecific::Private
55

66
from Node n1, ContentSet f, Node n2
77
where
8-
(
9-
readSet(n1, f, n2) or
10-
getterStep(n1, f, n2)
11-
) and
8+
readSet(n1, f, n2) and
129
n1.getEnclosingCallable().fromSource()
1310
select n1, n2, f

0 commit comments

Comments
 (0)