Fix plugin settings for GitExtensions-v3.3.1.

maraf · maraf · commit 0824aa9ac578 · 2020-01-15T21:54:33.000+01:00
Use base constructor of GitPluginBase with boolean parameter
to indicate that plugin has settings.
diff --git a/src/GitExtensions.PluginManager/Plugin.cs b/src/GitExtensions.PluginManager/Plugin.cs
@@ -29,6 +29,7 @@ public class Plugin : GitPluginBase
         internal PluginSettings Configuration { get; private set; }
 
         public Plugin()
+            : base(PluginSettings.HasProperties)
         {
             Name = "Plugin Manager";
             Description = "Plugin Manager";
diff --git a/src/GitExtensions.PluginManager/PluginSettings.cs b/src/GitExtensions.PluginManager/PluginSettings.cs
@@ -31,6 +31,8 @@ public PluginSettings(ISettingsSource source)
 
         private static readonly List<ISetting> properties;
 
+        public static bool HasProperties => properties.Count > 0;
+
         static PluginSettings()
         {
             properties = new List<ISetting>(1)

Original file line number	Diff line number	Diff line change
`@@ -29,6 +29,7 @@ public class Plugin : GitPluginBase`
`29`	`29`	`internal PluginSettings Configuration { get; private set; }`
`30`	`30`
`31`	`31`	`public Plugin()`
	`32`	`+ : base(PluginSettings.HasProperties)`
`32`	`33`	`{`
`33`	`34`	`Name = "Plugin Manager";`
`34`	`35`	`Description = "Plugin Manager";`
Original file line number	Diff line number	Diff line change
`@@ -31,6 +31,8 @@ public PluginSettings(ISettingsSource source)`
`31`	`31`
`32`	`32`	`private static readonly List<ISetting> properties;`
`33`	`33`
	`34`	`+ public static bool HasProperties => properties.Count > 0;`
	`35`	`+`
`34`	`36`	`static PluginSettings()`
`35`	`37`	`{`
`36`	`38`	`properties = new List<ISetting>(1)`