Skip to content

Commit fbec174

Browse files
authored
fix: filtering query params (#43)
## Description Fixes query filtering on `getStrategies` method of strategy registry repository ## Checklist before requesting a review - [x] I have conducted a self-review of my code. - [x] I have conducted a QA. - [x] If it is a core feature, I have included comprehensive tests.
1 parent eb7e1c3 commit fbec174

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

packages/repository/src/repositories/kysely/strategyRegistry.repository.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -37,16 +37,16 @@ export class KyselyStrategyRegistryRepository implements IStrategyRegistryReposi
3737

3838
/** @inheritdoc */
3939
async getStrategies(filters?: { handled?: boolean; chainId?: ChainId }): Promise<Strategy[]> {
40-
const query = this.db.withSchema(this.schemaName).selectFrom("strategies");
40+
let query = this.db.withSchema(this.schemaName).selectFrom("strategies").selectAll();
4141

4242
if (filters?.chainId) {
43-
query.where("chainId", "=", filters.chainId);
43+
query = query.where("chainId", "=", filters.chainId);
4444
}
4545

46-
if (filters?.handled) {
47-
query.where("handled", "=", filters.handled);
46+
if (filters?.handled !== undefined && filters?.handled !== null) {
47+
query = query.where("handled", "=", filters.handled);
4848
}
4949

50-
return query.selectAll().execute();
50+
return query.execute();
5151
}
5252
}

0 commit comments

Comments
 (0)