Skip to content

GitButler doesn't recognize allowed GitHub PR merge methods #8403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jackTabsCode opened this issue May 5, 2025 · 1 comment
Open

GitButler doesn't recognize allowed GitHub PR merge methods #8403

jackTabsCode opened this issue May 5, 2025 · 1 comment
Labels
bug Something isn't working UI Any broken visuals like layouts, colors etc.

Comments

@jackTabsCode
Copy link

Version

0.14.19

Operating System

macOS

Distribution Method

dmg (Mac OS - Apple Silicon)

Describe the issue

When trying to merge a PR in GitButler with a method that is not allowed in your GitHub repository's settings, GitButler will do nothing and output no error.

How to reproduce (Optional)

  1. Create a repository and turn off "Allow rebase merging" and "Allow merge commits"
  2. Make some changes and create a PR with GitButler
  3. Attempt to merge the pull request using a default option
  4. Nothing happens
  5. Switch the method to squash, squash and merge
  6. It works

Expected behavior (Optional)

GitButler should grey out these options like on the web PR view.

Relevant log output (Optional)

@jackTabsCode jackTabsCode added the bug Something isn't working label May 5, 2025
@Byron Byron added the UI Any broken visuals like layouts, colors etc. label May 6, 2025
@Byron
Copy link
Collaborator

Byron commented May 6, 2025

Thanks a lot for reporting!

Maybe as a start we could look into why failures to interact with forges don't propagate so they are user-observable. Maybe there even is a general way of tackling this, but @estib-vega certainly has ideas as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working UI Any broken visuals like layouts, colors etc.
Projects
None yet
Development

No branches or pull requests

2 participants