Skip to content

Reddit pages are 60 MB - 90 MB #1387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gitressa opened this issue Feb 12, 2024 · 18 comments
Closed

Reddit pages are 60 MB - 90 MB #1387

gitressa opened this issue Feb 12, 2024 · 18 comments

Comments

@gitressa
Copy link

Describe the bug
Thanks for a great add-on, it's really nice to have.

To Reproduce
Steps to reproduce the behavior:

  1. Go to a Reddit page
  2. Save the page
  3. See that it is 50-90 MB

Expected behavior
I would expect it to be 2-3 MB.

Environment

  • OS: Ubuntu 20.04
  • Browser: Firefox
  • Version: 1.22.40
@gildas-lormeau
Copy link
Owner

Unfortunately, for some reasons I cannot explain, the developers decided to inline and duplicate all the stylesheets in the new version of Reddit and it inevitably leads to this kind of result. For example, https://www.reddit.com/r/webdev/ contains more than 600 stylesheets. For the moment I don't see how I can get around this problem, apart from saving pages while logged in on Reddit.

@gitressa
Copy link
Author

Thanks for a fast answer. It also happens when you are logged in.

@iG8R
Copy link

iG8R commented Mar 3, 2024

Same issue here... it is incomprehensible how 1 page can be ~90MB...

@gildas-lormeau
Copy link
Owner

gildas-lormeau commented Sep 9, 2024

This issue is fixed in the last version of SingleFile. I attached a ZIP file containing the recommended settings for Reddit which you can import via the options page in SingleFile. Otherwise, please enable the option Stylesheets > group duplicate stylesheets together.

singlefile-settings-reddit.json.zip

@gitressa
Copy link
Author

Thanks! I don't see the Stylesheets > group duplicate stylesheets together option, but Reddit pages are now only ~1 MB, so something has been updated, and the issue has been fixed.

@iG8R
Copy link

iG8R commented Sep 11, 2024

@gildas-lormeau
Could you please also publish the Firefox addon on the releases page when a new one is released, because https://addons.mozilla.org/en-US/firefox/addon/single-file/ is not updated in a timely manner.

@gildas-lormeau
Copy link
Owner

The publish is in progress. Mozilla takes usually approx. 1 week to review the code.

@iG8R
Copy link

iG8R commented Sep 11, 2024

That's why I asked you to publish the addon on the release page, because you don't have to wait for Mozilla to review the code.

@gildas-lormeau
Copy link
Owner

Sorry for the misunderstanding, it looks like I was a bit tired. Actually, I cannot get an xpi file until Mozilla has reviewed the code. You can install the extension manually though. See here: https://github.com/gildas-lormeau/SingleFile?tab=readme-ov-file#install

@iG8R
Copy link

iG8R commented Sep 12, 2024

Thanks a lot for the suggestion, too bad you can't get the xpi file. I used to do what you suggested, but it's so inconvenient that I have to reinstall the addon after every restart of Firefox.

@gildas-lormeau
Copy link
Owner

gildas-lormeau commented Sep 12, 2024

Regarding the persistence of the extension, maybe one of these suggestions using web-ext would work, I did not test them:

@gildas-lormeau
Copy link
Owner

The new version has been published.

@iG8R
Copy link

iG8R commented Sep 12, 2024

Thank you very much!

@gitressa
Copy link
Author

Just adding a tip that Stylesheets > group duplicate stylesheets together seems to have been disabled, and Reddit pages were again big. (Or maybe I reinstalled the add-on?) Anyway, after enabling, they are again small. Thanks!

@gildas-lormeau
Copy link
Owner

@gitressa That's stange, this should not happen. Is the "sync" option enabled in your settings?

@gitressa
Copy link
Author

No, "synchronize options" is not enabled ... but it says "Check this option to synchronize your options and make them available in all instances of the browser you are logged into, on different devices." and I am only on a single device ...

Or does it do more than that text describes?

@gildas-lormeau
Copy link
Owner

As far as I know, this is the only case in which the settings could be reset. It's still pretty strange... Please do not hesitate to contact me if you find that the option Stylesheets > group duplicate stylesheets together deactivates itself again.

@gitressa
Copy link
Author

Thanks, I'll keep an eye on it. Thanks for a great add-on!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants