You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While troubleshooting some issues with penpot thumbnails, I was looking in the network requests tabs, and I saw a few errors related to my url. Network requests are being made to umbrel.local, but umbrel.local was not defined for me. Instead, I use local-server:
I managed to work around this issue by adding umbrel.local to my hosts file, and looking through the codebase for umbrel-apps I can see DEVICE_DOMAIN_NAME is used for the URI:
Further searching reveals that this is standard OP throughout the umbrel-apps codebase. However, users may prefer a different domain name, and I don't think the existing guides specify any particular requirements for choosing a hostname, so making this assumption in the various app configurations may lead to further instability issues for users.
If there is a requirement that the hostname needs to be umbrel.local, that should be expressed as a requirement. Otherwise, these configurations should be flexible enough to handle different hostname configurations.
I hope this isn't off base, it just seems like one of those things that could increase instability and reported issues across a few apps. Lastly, thanks for all your time and dedication to making this a great app, I use my umbrel server every day and I appreciate you for the work you do. Thanks!
The text was updated successfully, but these errors were encountered:
Seeing the actual issue now in that network request, the asset is being requested without a port, so umbrel's front-end is responding (resulting in a corbs error on umbrel.local). Adding the port to the request resolves to the actual asset in my testing.
While troubleshooting some issues with penpot thumbnails, I was looking in the network requests tabs, and I saw a few errors related to my url. Network requests are being made to
umbrel.local
, butumbrel.local
was not defined for me. Instead, I use local-server:I managed to work around this issue by adding umbrel.local to my hosts file, and looking through the codebase for umbrel-apps I can see
DEVICE_DOMAIN_NAME
is used for the URI:Further searching reveals that this is standard OP throughout the umbrel-apps codebase. However, users may prefer a different domain name, and I don't think the existing guides specify any particular requirements for choosing a hostname, so making this assumption in the various app configurations may lead to further instability issues for users.
If there is a requirement that the hostname needs to be umbrel.local, that should be expressed as a requirement. Otherwise, these configurations should be flexible enough to handle different hostname configurations.
I hope this isn't off base, it just seems like one of those things that could increase instability and reported issues across a few apps. Lastly, thanks for all your time and dedication to making this a great app, I use my umbrel server every day and I appreciate you for the work you do. Thanks!
The text was updated successfully, but these errors were encountered: