Skip to content

Commit 8d836ea

Browse files
feat(starfish): Retry on 429s and increase exponential backoff (#52273)
Retries starfish requests on 429 errors and backoff with an exponentially increasing duration
1 parent 306fb92 commit 8d836ea

File tree

4 files changed

+28
-4
lines changed

4 files changed

+28
-4
lines changed

static/app/views/starfish/queries/useTransactions.tsx

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,10 @@ import {useDiscoverQuery} from 'sentry/utils/discover/discoverQuery';
22
import EventView from 'sentry/utils/discover/eventView';
33
import {useLocation} from 'sentry/utils/useLocation';
44
import useOrganization from 'sentry/utils/useOrganization';
5+
import {
6+
getRetryDelay,
7+
shouldRetryHandler,
8+
} from 'sentry/views/starfish/utils/retryHandlers';
59

610
type Transaction = {
711
id: string;
@@ -35,7 +39,8 @@ export function useTransactions(eventIDs: string[], referrer = 'use-transactions
3539
options: {
3640
enabled,
3741
refetchOnWindowFocus: false,
38-
retry: false,
42+
retry: shouldRetryHandler,
43+
retryDelay: getRetryDelay,
3944
staleTime: Infinity,
4045
},
4146
});
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
export function shouldRetryHandler(failureCount: number, error: Error) {
2+
return failureCount < 3 && error.message.includes('429');
3+
}
4+
5+
export function getRetryDelay(attempt: number) {
6+
return 1000 * Math.pow(3, attempt);
7+
}

static/app/views/starfish/utils/useEventsStatsQuery.tsx

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,10 @@ import {
66
} from 'sentry/utils/discover/genericDiscoverQuery';
77
import {useLocation} from 'sentry/utils/useLocation';
88
import useOrganization from 'sentry/utils/useOrganization';
9+
import {
10+
getRetryDelay,
11+
shouldRetryHandler,
12+
} from 'sentry/views/starfish/utils/retryHandlers';
913

1014
export function useEventsStatsQuery({
1115
eventView,
@@ -39,8 +43,10 @@ export function useEventsStatsQuery({
3943
}),
4044
options: {
4145
enabled,
42-
retry: false,
4346
refetchOnWindowFocus: false,
47+
retry: shouldRetryHandler,
48+
retryDelay: getRetryDelay,
49+
staleTime: Infinity,
4450
},
4551
referrer,
4652
});

static/app/views/starfish/utils/useSpansQuery.tsx

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,10 @@ import {
1313
import {useLocation} from 'sentry/utils/useLocation';
1414
import useOrganization from 'sentry/utils/useOrganization';
1515
import usePageFilters from 'sentry/utils/usePageFilters';
16+
import {
17+
getRetryDelay,
18+
shouldRetryHandler,
19+
} from 'sentry/views/starfish/utils/retryHandlers';
1620
import {TrackResponse} from 'sentry/views/starfish/utils/trackResponse';
1721

1822
export const DATE_FORMAT = 'YYYY-MM-DDTHH:mm:ssZ';
@@ -97,7 +101,8 @@ export function useWrappedDiscoverTimeseriesQuery<T>({
97101
options: {
98102
enabled,
99103
refetchOnWindowFocus: false,
100-
retry: false,
104+
retry: shouldRetryHandler,
105+
retryDelay: getRetryDelay,
101106
staleTime: Infinity,
102107
},
103108
referrer,
@@ -142,7 +147,8 @@ export function useWrappedDiscoverQuery<T>({
142147
options: {
143148
enabled,
144149
refetchOnWindowFocus: false,
145-
retry: false,
150+
retry: shouldRetryHandler,
151+
retryDelay: getRetryDelay,
146152
staleTime: Infinity,
147153
},
148154
});

0 commit comments

Comments
 (0)