Skip to content

Commit e1ea4a8

Browse files
fix(ci): update sample app build target to generic ios simulator (#4276)
1 parent 57448c5 commit e1ea4a8

File tree

2 files changed

+10
-6
lines changed

2 files changed

+10
-6
lines changed

.github/workflows/sample-application.yml

+8-6
Original file line numberDiff line numberDiff line change
@@ -36,11 +36,9 @@ jobs:
3636
build-type: ['dev', 'production']
3737
include:
3838
- platform: ios
39-
runs-on: macos-14 # uses m1 https://github.blog/changelog/2024-01-30-github-actions-macos-14-sonoma-is-now-available/
40-
runtime: 'latest'
41-
device: 'iPhone 14'
39+
runs-on: macos-15
4240
- platform: macos
43-
runs-on: macos-14
41+
runs-on: macos-15
4442
- platform: android
4543
runs-on: ubuntu-latest
4644
exclude:
@@ -55,7 +53,10 @@ jobs:
5553
steps:
5654
- uses: actions/checkout@v4
5755

58-
- run: corepack enable
56+
- name: Enable Corepack
57+
run: |
58+
npm install -g [email protected]
59+
corepack enable
5960
- uses: actions/setup-node@v4
6061
with:
6162
node-version: 18
@@ -132,7 +133,8 @@ jobs:
132133
-workspace sentryreactnativesample.xcworkspace \
133134
-configuration "$CONFIG" \
134135
-scheme sentryreactnativesample \
135-
-destination 'platform=iOS Simulator,OS=${{ matrix.runtime }},name=${{ matrix.device }}' \
136+
-sdk 'iphonesimulator' \
137+
-destination 'generic/platform=iOS Simulator' \
136138
ONLY_ACTIVE_ARCH=yes \
137139
-derivedDataPath "$derivedData" \
138140
build \

samples/react-native/ios/sentryreactnativesample.xcodeproj/project.pbxproj

+2
Original file line numberDiff line numberDiff line change
@@ -498,6 +498,7 @@
498498
buildSettings = {
499499
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
500500
CLANG_ENABLE_MODULES = YES;
501+
CODE_SIGN_IDENTITY = "Apple Development";
501502
"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Distribution";
502503
CODE_SIGN_STYLE = Manual;
503504
CURRENT_PROJECT_VERSION = 1;
@@ -532,6 +533,7 @@
532533
buildSettings = {
533534
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
534535
CLANG_ENABLE_MODULES = YES;
536+
CODE_SIGN_IDENTITY = "Apple Development";
535537
"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Distribution";
536538
CODE_SIGN_STYLE = Manual;
537539
CURRENT_PROJECT_VERSION = 1;

0 commit comments

Comments
 (0)