Skip to content

Commit 7f8571c

Browse files
ref: Remove _capture_experimental_log scope parameter (#4424)
We are always just using the current scope anyway; it is less confusing if we eliminate the parameter Stacked on: - #4423
1 parent a662a9d commit 7f8571c

File tree

3 files changed

+9
-10
lines changed

3 files changed

+9
-10
lines changed

sentry_sdk/client.py

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
from typing import TYPE_CHECKING, List, Dict, cast, overload
99
import warnings
1010

11+
import sentry_sdk
1112
from sentry_sdk._compat import PY37, check_uwsgi_thread_support
1213
from sentry_sdk.utils import (
1314
AnnotatedValue,
@@ -215,8 +216,8 @@ def capture_event(self, *args, **kwargs):
215216
# type: (*Any, **Any) -> Optional[str]
216217
return None
217218

218-
def _capture_experimental_log(self, scope, log):
219-
# type: (Scope, Log) -> None
219+
def _capture_experimental_log(self, log):
220+
# type: (Log) -> None
220221
pass
221222

222223
def capture_session(self, *args, **kwargs):
@@ -893,12 +894,14 @@ def capture_event(
893894

894895
return return_value
895896

896-
def _capture_experimental_log(self, current_scope, log):
897-
# type: (Scope, Log) -> None
897+
def _capture_experimental_log(self, log):
898+
# type: (Log) -> None
898899
logs_enabled = self.options["_experiments"].get("enable_logs", False)
899900
if not logs_enabled:
900901
return
901-
isolation_scope = current_scope.get_isolation_scope()
902+
903+
current_scope = sentry_sdk.get_current_scope()
904+
isolation_scope = sentry_sdk.get_isolation_scope()
902905

903906
log["attributes"]["sentry.sdk.name"] = SDK_INFO["name"]
904907
log["attributes"]["sentry.sdk.version"] = SDK_INFO["version"]

sentry_sdk/integrations/logging.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -352,7 +352,6 @@ def emit(self, record):
352352

353353
def _capture_log_from_record(self, client, record):
354354
# type: (BaseClient, LogRecord) -> None
355-
scope = sentry_sdk.get_current_scope()
356355
otel_severity_number, otel_severity_text = _python_level_to_otel(record.levelno)
357356
project_root = client.options["project_root"]
358357
attrs = self._extra_from_record(record) # type: Any
@@ -394,7 +393,6 @@ def _capture_log_from_record(self, client, record):
394393

395394
# noinspection PyProtectedMember
396395
client._capture_experimental_log(
397-
scope,
398396
{
399397
"severity_text": otel_severity_text,
400398
"severity_number": otel_severity_number,

sentry_sdk/logger.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,13 @@
33
import time
44
from typing import Any
55

6-
from sentry_sdk import get_client, get_current_scope
6+
from sentry_sdk import get_client
77
from sentry_sdk.utils import safe_repr
88

99

1010
def _capture_log(severity_text, severity_number, template, **kwargs):
1111
# type: (str, int, str, **Any) -> None
1212
client = get_client()
13-
scope = get_current_scope()
1413

1514
attrs = {
1615
"sentry.message.template": template,
@@ -36,7 +35,6 @@ def _capture_log(severity_text, severity_number, template, **kwargs):
3635

3736
# noinspection PyProtectedMember
3837
client._capture_experimental_log(
39-
scope,
4038
{
4139
"severity_text": severity_text,
4240
"severity_number": severity_number,

0 commit comments

Comments
 (0)