-
-
Notifications
You must be signed in to change notification settings - Fork 222
Add e2e test #4174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@bruno-garcia is there a reference to the issue describing the symbolication difficulties? What kind of end to end tests are we talking about? Different to the integration tests? |
@jamescrosswell this came up in an offline meeting. The issue with current integration tests in the dotnet repo is that they only run locally, against a fake sentry server (a python script that prints out what it has received). This is fast and provides baseline checks what has been sent to the server by the CLI during build. I'm assigned here because I've volunteered to prepare the scaffolding and some basic test as an example, because I have experience with these in other repos. There can be more tests added in the future, ideally by sentry-dotnet SDK maintainers. |
Cool, thanks @vaind - that sounds a bit step up. |
We recently had symbolication related issues that would have been caught had we tested the SDK through Sentry itself.
Other repos have this, like React Native.
The text was updated successfully, but these errors were encountered: