Skip to content

Commit b241c4a

Browse files
feat: Remove organization and project info log (#2490)
These appear to have been originally added in #670; however, we have not adopted these info logs consistently across all of our commands, and we believe they are likely not very useful. Since some of these commands are going to be modified to accept multiple projects, the info log would anyways need to be reworked if we were to keep it; however, it is simpler just to get rid of the log for now.
1 parent 046ab9d commit b241c4a

File tree

8 files changed

+8
-52
lines changed

8 files changed

+8
-52
lines changed

src/commands/debug_files/upload.rs

-6
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ use anyhow::{bail, format_err, Result};
66
use clap::{builder::PossibleValuesParser, Arg, ArgAction, ArgMatches, Command};
77
use console::style;
88
use itertools::Itertools;
9-
use log::info;
109
use symbolic::common::DebugId;
1110
use symbolic::debuginfo::FileFormat;
1211

@@ -219,11 +218,6 @@ pub fn execute(matches: &ArgMatches) -> Result<()> {
219218
.unwrap_or_default()
220219
.copied();
221220

222-
info!(
223-
"Issuing a command for Organization: {} Project: {}",
224-
org, project
225-
);
226-
227221
let wait_for_secs = matches.get_one::<u64>("wait_for").copied();
228222
let wait = matches.get_flag("wait") || wait_for_secs.is_some();
229223
let max_wait = wait_for_secs.map_or(DEFAULT_MAX_WAIT, Duration::from_secs);

src/commands/issues/mute.rs

+4-9
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
use anyhow::Result;
22
use clap::{ArgMatches, Command};
3-
use log::info;
43

54
use crate::api::{Api, IssueChanges, IssueFilter};
65
use crate::config::Config;
@@ -13,14 +12,10 @@ pub fn execute(matches: &ArgMatches) -> Result<()> {
1312
let config = Config::current();
1413
let (org, project) = config.get_org_and_project(matches)?;
1514
let filter = IssueFilter::get_filter_from_matches(matches)?;
16-
let mut changes: IssueChanges = Default::default();
17-
18-
info!(
19-
"Issuing a command for Organization: {} Project: {}",
20-
org, project
21-
);
22-
23-
changes.new_status = Some("muted".into());
15+
let changes = IssueChanges {
16+
new_status: Some("muted".into()),
17+
..Default::default()
18+
};
2419

2520
if Api::current()
2621
.authenticated()?

src/commands/issues/resolve.rs

-6
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
use anyhow::Result;
22
use clap::{Arg, ArgAction, ArgMatches, Command};
3-
use log::info;
43

54
use crate::api::{Api, IssueChanges, IssueFilter};
65
use crate::config::Config;
@@ -21,11 +20,6 @@ pub fn execute(matches: &ArgMatches) -> Result<()> {
2120
let filter = IssueFilter::get_filter_from_matches(matches)?;
2221
let mut changes: IssueChanges = Default::default();
2322

24-
info!(
25-
"Issuing a command for Organization: {} Project: {}",
26-
org, project
27-
);
28-
2923
if matches.get_flag("next_release") {
3024
changes.new_status = Some("resolvedInNextRelease".into());
3125
} else {

src/commands/issues/unresolve.rs

+4-9
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
use anyhow::Result;
22
use clap::{ArgMatches, Command};
3-
use log::info;
43

54
use crate::api::{Api, IssueChanges, IssueFilter};
65
use crate::config::Config;
@@ -13,14 +12,10 @@ pub fn execute(matches: &ArgMatches) -> Result<()> {
1312
let config = Config::current();
1413
let (org, project) = config.get_org_and_project(matches)?;
1514
let filter = IssueFilter::get_filter_from_matches(matches)?;
16-
let mut changes: IssueChanges = Default::default();
17-
18-
info!(
19-
"Issuing a command for Organization: {} Project: {}",
20-
org, project
21-
);
22-
23-
changes.new_status = Some("unresolved".into());
15+
let changes = IssueChanges {
16+
new_status: Some("unresolved".into()),
17+
..Default::default()
18+
};
2419

2520
if Api::current()
2621
.authenticated()?

src/commands/react_native/appcenter.rs

-6
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ use anyhow::{anyhow, Result};
77
use clap::{Arg, ArgAction, ArgMatches, Command};
88
use console::style;
99
use if_chain::if_chain;
10-
use log::info;
1110

1211
use crate::api::Api;
1312
use crate::config::Config;
@@ -122,11 +121,6 @@ pub fn execute(matches: &ArgMatches) -> Result<()> {
122121
let api = Api::current();
123122
let print_release_name = matches.get_flag("print_release_name");
124123

125-
info!(
126-
"Issuing a command for Organization: {} Project: {}",
127-
org, project
128-
);
129-
130124
if !print_release_name {
131125
println!(
132126
"{} Fetching latest AppCenter deployment info",

src/commands/react_native/gradle.rs

-5
Original file line numberDiff line numberDiff line change
@@ -82,11 +82,6 @@ pub fn execute(matches: &ArgMatches) -> Result<()> {
8282
);
8383
let bundle_url = format!("~/{}", bundle_path.file_name().unwrap().to_string_lossy());
8484

85-
info!(
86-
"Issuing a command for Organization: {} Project: {}",
87-
org, project
88-
);
89-
9085
println!("Processing react-native sourcemaps for Sentry upload.");
9186
info!(" bundle path: {}", bundle_path.display());
9287
info!(" sourcemap path: {}", sourcemap_path.display());

src/commands/react_native/xcode.rs

-5
Original file line numberDiff line numberDiff line change
@@ -170,11 +170,6 @@ pub fn execute(matches: &ArgMatches) -> Result<()> {
170170
}
171171
.canonicalize()?;
172172

173-
info!(
174-
"Issuing a command for Organization: {} Project: {}",
175-
org, project
176-
);
177-
178173
// if we allow fetching and we detect a simulator run, then we need to switch
179174
// to simulator mode.
180175
let fetch_url;

src/commands/upload_proguard.rs

-6
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ use anyhow::{bail, Error, Result};
55
use clap::ArgAction;
66
use clap::{Arg, ArgMatches, Command};
77
use console::style;
8-
use log::info;
98
use symbolic::common::ByteView;
109
use uuid::Uuid;
1110

@@ -248,11 +247,6 @@ pub fn execute(matches: &ArgMatches) -> Result<()> {
248247
println!("{} uploading mappings", style(">").dim());
249248
(org, project) = config.get_org_and_project(matches)?;
250249

251-
info!(
252-
"Issuing a command for Organization: {} Project: {}",
253-
org, project
254-
);
255-
256250
authenticated_api = api.authenticated()?;
257251

258252
let rv = authenticated_api

0 commit comments

Comments
 (0)