Skip to content

Improve automatic tagging of Composables #855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
romtsn opened this issue Mar 21, 2025 · 1 comment
Open

Improve automatic tagging of Composables #855

romtsn opened this issue Mar 21, 2025 · 1 comment

Comments

@romtsn
Copy link
Member

romtsn commented Mar 21, 2025

Description

Currently our automatic tagging through the compiler plugin is suboptimal, because we're using a Composable name for SentryTag which can be default composable names like Image/Text/Slider etc. and which don't uniquely identify the composable.

We could use filename + function name + lineno to uniquely identify composables and make the ViewHierarchies and Transactions better represent what components are being traced.

Prior art: https://github.com/VKCOM/vkompose/blob/master/compiler-plugin/compose-test-tag/applier/plugin/src/main/kotlin/com/vk/compiler/plugin/compose/test/tag/applier/TestTagApplier.kt

@github-project-automation github-project-automation bot moved this to Needs Discussion in [DEPRECATED] Mobile SDKs Mar 21, 2025
@romtsn romtsn moved this from Needs Discussion to Backlog in [DEPRECATED] Mobile SDKs Mar 26, 2025
@romtsn
Copy link
Member Author

romtsn commented Mar 26, 2025

Let's have an opt-in flag in the beginning and add some tracking around it so we have an idea how widely adopted this is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

2 participants