fix(nx-heroku): make buildpacks option required

Author: getlarge

packages/nx-heroku/src/executors/common/heroku/plugins.ts

@@ -14,6 +14,5 @@ export async function hasPlugin(plugin: string): Promise<boolean> {
 }
 
 export async function installPlugin(plugin: string): Promise<void> {
-  const { stdout, stderr } = await exec(`heroku plugins:install ${plugin}`);
-  console.warn('installPlugin', stdout, stderr);
+  await exec(`heroku plugins:install ${plugin}`);
 }

packages/nx-heroku/src/executors/common/utils.ts

@@ -23,6 +23,7 @@ export function sleep(ms: number) {
   return new Promise((resolve) => setTimeout(resolve, ms));
 }
 
+// TODO: refactor to be more performant and efficient, running expand on each object option is (probably) not really efficient
 export function expandOptions<O extends object>(options: O): O {
   // iterate over 1 nested level objects
   const parsedNested = Object.entries(options).reduce((acc, curr) => {

packages/nx-heroku/src/executors/deploy/schema.d.ts

@@ -1,11 +1,12 @@
 import { ExecutorBaseSchema } from '../common/base-schema';
 import { Environment } from '../common/constants';
 
-export interface DeployExecutorSchema extends Omit<ExecutorBaseSchema, 'config'> {
+export interface DeployExecutorSchema
+  extends Omit<ExecutorBaseSchema, 'config'> {
   config: Environment[];
   org: string;
   repositoryName?: string;
-  buildPacks?: string[];
+  buildPacks: string[];
   variables?: Record<string, string>;
   addons?: { addonAlias?: string; addonName: string }[];
   webhook?: {

packages/nx-heroku/src/executors/deploy/schema.json

@@ -189,5 +189,5 @@
       "type": "boolean"
     }
   },
-  "required": ["config", "apiKey", "email", "org", "watchDelay"]
+  "required": ["config", "apiKey", "email", "org", "buildPacks", "watchDelay"]
 }

packages/nx-heroku/src/executors/deploy/services/heroku-app.service.ts

@@ -163,17 +163,15 @@ class HerokuApp {
 
   private async addBuildPacks(): Promise<void> {
     const { appName, buildPacks } = this.options;
-    if (buildPacks?.length) {
-      if (!(await hasPlugin('buildpack-registry'))) {
-        await installPlugin('buildpack-registry');
-      }
-      this.logger.info(`Clearing and adding buildpacks...`);
-      await clearBuildPacks({ appName });
-      for (const [i, buildPack] of buildPacks.entries()) {
-        await addBuildPack({ appName, buildPack, index: i + 1 });
-      }
-      this.logger.info(`Buildpacks ${buildPacks} added.`);
+    if (!(await hasPlugin('buildpack-registry'))) {
+      await installPlugin('buildpack-registry');
+    }
+    this.logger.info(`Clearing and adding buildpacks...`);
+    await clearBuildPacks({ appName });
+    for (const [i, buildPack] of buildPacks.entries()) {
+      await addBuildPack({ appName, buildPack, index: i + 1 });
     }
+    this.logger.info(`Buildpacks ${buildPacks} added.`);
   }
 
   private createStatic(): Promise<void> {