Skip to content

Commit 02a0f88

Browse files
committed
fix: separate post targets and add quotes to generated changelog
1 parent 5e0c864 commit 02a0f88

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

.github/workflows/test.yml

+1
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,7 @@ jobs:
6969
if: steps.has-coverage.outputs.files_exists == 'true'
7070
run: node tools/merge-coverage.js -c coverage
7171

72+
# should be uploaded only once theoretically...
7273
- name: Upload merged coverage reports
7374
if: steps.has-coverage.outputs.files_exists == 'true'
7475
uses: actions/upload-artifact@v3

packages/nx-heroku/project.json

+1-2
Original file line numberDiff line numberDiff line change
@@ -77,8 +77,7 @@
7777
"trackDeps": false,
7878
"push": true,
7979
"skipCommitTypes": ["docs", "ci"],
80-
"commitMessageFormat": "chore(${projectName}): release version ${version} [skip ci]",
81-
"postTargets": ["nx-heroku:npm", "nx-heroku:github"]
80+
"commitMessageFormat": "chore(${projectName}): release version ${version} [skip ci]"
8281
}
8382
},
8483
"github": {

tools/create-release.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ const getTagName = (semver, projectName) => {
124124
verbose,
125125
});
126126

127-
execSync(`gh release create ${tag} -n ${versionChangelog}`);
127+
execSync(`gh release create ${tag} -n "${versionChangelog}"`);
128128
process.exit(0);
129129
} catch (error) {
130130
console.error(error);

0 commit comments

Comments
 (0)