Remove linkcheck test and move it to its own job (#245)

Remove the linkcheck tests from tests.py. Run a make linkcheck in GitHub
Actions as its own job.

Author: santisoler

.github/workflows/test.yml

@@ -33,3 +33,31 @@ jobs:
 
       - name: Test with pytest
         run: pytest -s -v tests
+
+
+  linkcheck:
+    runs-on: ubuntu-latest
+    env:
+      PYTHON: "3.9"
+
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
+        with:
+          persist-credentials: false
+
+      - name: Set up Python
+        uses: actions/setup-python@v2
+        with:
+          python-version: ${{ env.PYTHON }}
+
+      - name: Install dependencies
+        run: |
+          python -m pip install --upgrade pip
+          pip install -r requirements.txt -r requirements-dev.txt
+
+      - name: List installed packages
+        run: pip list
+
+      - name: Check links
+        run: make linkcheck

tests/test_docs.py

@@ -36,16 +36,6 @@ def test_images(self):
     #         "%s"%(latex_path)])
     #     assert check == 0
 
-    def test_linkcheck(self):
-        doctrees_path = os.path.sep.join(self.path_to_docs.split(os.path.sep) + ['_build']+['doctrees'])
-        link_path = os.path.sep.join(self.path_to_docs.split(os.path.sep) + ['_build'])
-
-        check = subprocess.call(["sphinx-build", "-nW", "-b", "linkcheck", "-d",
-            "%s"%(doctrees_path),
-            "%s"%(self.path_to_docs),
-            "%s"%(link_path)])
-        assert check == 0
-
 
 if __name__ == '__main__':
     unittest.main()