-
Notifications
You must be signed in to change notification settings - Fork 51
Decouple proj and proj-sys tests #231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I'm really confused now. It passed last time: https://github.com/georust/proj/actions/runs/14513724387 I'm gonna try to merge it and then see where we are. |
Yeah true. It just means that proj wouldn't be publishable before the new proj-sys was published, right? Even if you have a path dependency, you can still get a version mismatch if your dep is on 0.25.0 but you ask for 0.26.0. Anyway seeing as how the CI on #228 was passing but not being reported, I bypassed the merge queue and now #230 is a PR (with passing CI) for new releases of both crates. In any case it's still annoying to have proj-sys CI gated on proj tests passing. |
I think it makes sense, what if we inadvertently break the most important consumer ( |
It's a sys crate with its own tests, so if a consumer breaks then the consumer is the "problem"? |
Once again, the fact that we run the same test suite for
proj
andproj-sys
is causing problems: #230 can't be merged because it requires theproj
tests to pass, but that's blocked on #228, which is blocked on #230, so we now have to decide whether we want to manually merge #230 and push a release. Is there some sensible way of doing this?The text was updated successfully, but these errors were encountered: