Skip to content

Commit 8b1d800

Browse files
jwnimmer-triazeey
authored andcommitted
Don't include the gz/math.hh header from library code (#1043)
Using overly-broad include statements leads to slower builds and bloated object code. Signed-off-by: Jeremy Nimmer <[email protected]>
1 parent a428e2a commit 8b1d800

File tree

3 files changed

+11
-2
lines changed

3 files changed

+11
-2
lines changed

include/sdf/Link.hh

+1
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919

2020
#include <memory>
2121
#include <string>
22+
#include <ignition/math/Inertial.hh>
2223
#include <ignition/math/Pose3.hh>
2324
#include "sdf/Element.hh"
2425
#include "sdf/SemanticPose.hh"

include/sdf/Param.hh

+6-1
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,12 @@
3030
#include <variant>
3131
#include <vector>
3232

33-
#include <ignition/math.hh>
33+
#include <ignition/math/Angle.hh>
34+
#include <ignition/math/Color.hh>
35+
#include <ignition/math/Pose3.hh>
36+
#include <ignition/math/Quaternion.hh>
37+
#include <ignition/math/Vector2.hh>
38+
#include <ignition/math/Vector3.hh>
3439

3540
#include "sdf/Console.hh"
3641
#include "sdf/sdf_config.h"

src/parser_urdf.cc

+4-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,10 @@
2525
#include <utility>
2626
#include <vector>
2727

28-
#include <ignition/math.hh>
28+
#include <ignition/math/Helpers.hh>
29+
#include <ignition/math/Pose3.hh>
30+
#include <ignition/math/Quaternion.hh>
31+
#include <ignition/math/Vector3.hh>
2932

3033
#include <urdf_model/model.h>
3134
#include <urdf_model/link.h>

0 commit comments

Comments
 (0)