Skip to content

Commit ecc591c

Browse files
ahcordechapulina
andauthored
Added renderOrder to convert functions (#514)
* Added renderOrder to convert functions Signed-off-by: ahcorde <[email protected]> * Added renderOrder to conversion_TEST Signed-off-by: ahcorde <[email protected]> * fixed conversion tests Signed-off-by: ahcorde <[email protected]> Co-authored-by: Louise Poubel <[email protected]>
1 parent 63a88dc commit ecc591c

File tree

3 files changed

+6
-0
lines changed

3 files changed

+6
-0
lines changed

src/Conversions.cc

+2
Original file line numberDiff line numberDiff line change
@@ -270,6 +270,7 @@ msgs::Material ignition::gazebo::convert(const sdf::Material &_in)
270270
msgs::Set(out.mutable_diffuse(), _in.Diffuse());
271271
msgs::Set(out.mutable_specular(), _in.Specular());
272272
msgs::Set(out.mutable_emissive(), _in.Emissive());
273+
out.set_render_order(_in.RenderOrder());
273274
out.set_lighting(_in.Lighting());
274275

275276
// todo(anyone) add double_sided field to msgs::Material
@@ -330,6 +331,7 @@ sdf::Material ignition::gazebo::convert(const msgs::Material &_in)
330331
out.SetDiffuse(msgs::Convert(_in.diffuse()));
331332
out.SetSpecular(msgs::Convert(_in.specular()));
332333
out.SetEmissive(msgs::Convert(_in.emissive()));
334+
out.SetRenderOrder(_in.render_order());
333335
out.SetLighting(_in.lighting());
334336

335337
// todo(anyone) add double_sided field to msgs::Material

src/Conversions_TEST.cc

+3
Original file line numberDiff line numberDiff line change
@@ -205,6 +205,7 @@ TEST(Conversions, Material)
205205
material.SetAmbient(ignition::math::Color(0.9f, 1.0f, 1.1f, 1.2f));
206206
material.SetEmissive(ignition::math::Color(1.3f, 1.4f, 1.5f, 1.6f));
207207
material.SetLighting(true);
208+
material.SetRenderOrder(2.5);
208209

209210
// todo(anyone) add double_sided field to msgs::Material
210211
material.SetDoubleSided(true);
@@ -237,6 +238,7 @@ TEST(Conversions, Material)
237238
EXPECT_EQ(math::Color(1.3f, 1.4f, 1.5f, 1.6f),
238239
msgs::Convert(materialMsg.emissive()));
239240
EXPECT_TRUE(materialMsg.lighting());
241+
EXPECT_DOUBLE_EQ(2.5, materialMsg.render_order());
240242

241243
// todo(anyone) double_sided is temporarily stored in header
242244
// Need to add double_sided field to msgs::Material
@@ -266,6 +268,7 @@ TEST(Conversions, Material)
266268
EXPECT_EQ(math::Color(1.3f, 1.4f, 1.5f, 1.6f), newMaterial.Emissive());
267269
EXPECT_TRUE(newMaterial.Lighting());
268270
EXPECT_TRUE(newMaterial.DoubleSided());
271+
EXPECT_DOUBLE_EQ(2.5, newMaterial.RenderOrder());
269272

270273
sdf::Pbr *newPbrMaterial = newMaterial.PbrMaterial();
271274
ASSERT_NE(nullptr, newPbrMaterial);

src/rendering/SceneManager.cc

+1
Original file line numberDiff line numberDiff line change
@@ -439,6 +439,7 @@ rendering::MaterialPtr SceneManager::LoadMaterial(
439439
material->SetDiffuse(_material.Diffuse());
440440
material->SetSpecular(_material.Specular());
441441
material->SetEmissive(_material.Emissive());
442+
material->SetRenderOrder(_material.RenderOrder());
442443

443444
// parse PBR params
444445
const sdf::Pbr *pbr = _material.PbrMaterial();

0 commit comments

Comments
 (0)