Skip to content

Commit 4695b88

Browse files
committed
check empty plugins, update issue url
Signed-off-by: Ian Chen <[email protected]>
1 parent 0ec7ad1 commit 4695b88

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

src/SystemManager.cc

+7-2
Original file line numberDiff line numberDiff line change
@@ -220,6 +220,13 @@ void SystemManager::ProcessPendingEntitySystems()
220220
{
221221
Entity entity = req.entity().id();
222222

223+
if (req.plugins().empty())
224+
{
225+
ignwarn << "Unable to add plugins to Entity: '" << entity
226+
<< "'. No plugins specified." << std::endl;
227+
continue;
228+
}
229+
223230
for (auto &pluginMsg : req.plugins())
224231
{
225232
std::string fname = pluginMsg.filename();
@@ -231,5 +238,3 @@ void SystemManager::ProcessPendingEntitySystems()
231238
}
232239
this->systemsToAdd.clear();
233240
}
234-
235-

test/integration/entity_system.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@ class EntitySystemTest : public InternalFixture<::testing::TestWithParam<int>>
149149
};
150150

151151
/////////////////////////////////////////////////
152-
// See https://github.com/ignitionrobotics/ign-gazebo/issues/1175
152+
// See https://github.com/gazebosim/gz-sim/issues/1175
153153
TEST_P(EntitySystemTest, IGN_UTILS_TEST_DISABLED_ON_WIN32(PublishCmd))
154154
{
155155
TestPublishCmd(

0 commit comments

Comments
 (0)