Skip to content

Commit 8b1d5b5

Browse files
authored
fix codecheck errors (#173)
Signed-off-by: Ashton Larkin <[email protected]>
1 parent 74d4f5d commit 8b1d5b5

File tree

2 files changed

+10
-4
lines changed

2 files changed

+10
-4
lines changed

ogre/src/OgreRenderEngine.cc

+5-2
Original file line numberDiff line numberDiff line change
@@ -493,8 +493,11 @@ void OgreRenderEngine::CreateRenderSystem()
493493
renderSys = rsList->at(c);
494494
c++;
495495
}
496-
while (renderSys &&
497-
renderSys->getName().compare("OpenGL Rendering Subsystem") != 0);
496+
// cpplint has a false positive when extending a while call to multiple lines
497+
// (it thinks the while loop is empty), so we must put the whole while
498+
// statement on one line and add NOLINT at the end so that cpplint doesn't
499+
// complain about the line being too long
500+
while (renderSys && renderSys->getName().compare("OpenGL Rendering Subsystem") != 0); // NOLINT
498501

499502
if (renderSys == nullptr)
500503
{

ogre2/src/Ogre2RenderEngine.cc

+5-2
Original file line numberDiff line numberDiff line change
@@ -476,8 +476,11 @@ void Ogre2RenderEngine::CreateRenderSystem()
476476
renderSys = rsList->at(c);
477477
c++;
478478
}
479-
while (renderSys &&
480-
renderSys->getName().compare("OpenGL 3+ Rendering Subsystem") != 0);
479+
// cpplint has a false positive when extending a while call to multiple lines
480+
// (it thinks the while loop is empty), so we must put the whole while
481+
// statement on one line and add NOLINT at the end so that cpplint doesn't
482+
// complain about the line being too long
483+
while (renderSys && renderSys->getName().compare("OpenGL 3+ Rendering Subsystem") != 0); // NOLINT
481484

482485
if (renderSys == nullptr)
483486
{

0 commit comments

Comments
 (0)