Provide a Virtual Method Anchor for Classes in Headers

Ref: https://llvm.org/docs/CodingStandards.html#provide-a-virtual-method-anchor-for-classes-in-headers

Signed-off-by: Michael Carroll <[email protected]>

Author: mjcarroll

include/gz/rendering/ArrowVisual.hh

@@ -32,7 +32,7 @@ namespace gz
       public virtual CompositeVisual
     {
       /// \brief Destructor
-      public: virtual ~ArrowVisual() { }
+      public: virtual ~ArrowVisual();
 
       /// \brief Get arrow-head visual
       /// \return The arrow-head visual

include/gz/rendering/AxisVisual.hh

@@ -32,7 +32,7 @@ namespace gz
       public virtual CompositeVisual
     {
       /// \brief Destructor
-      public: virtual ~AxisVisual() { }
+      public: virtual ~AxisVisual();
 
       /// \brief set true to show the axis heads, false otherwise
       /// \param[in] _b true to show the axis heads, false otherwise

include/gz/rendering/BoundingBoxCamera.hh

@@ -55,7 +55,7 @@ namespace gz
       public virtual Camera
     {
       /// \brief Destructor
-      public: virtual ~BoundingBoxCamera() { }
+      public: virtual ~BoundingBoxCamera();
 
       /// \brief Get the BoundingBox data
       /// \return Buffer of bounding boxes info (label, minX, minY, maxX, maxY).

include/gz/rendering/COMVisual.hh

@@ -37,7 +37,7 @@ namespace gz
       public virtual Visual
     {
       /// \brief Destructor
-      public: virtual ~COMVisual() {}
+      public: virtual ~COMVisual();
 
       /// \brief Set the inertial component of the visual
       /// \param[in] _inertial Inertial component of the visual

include/gz/rendering/Camera.hh

@@ -54,7 +54,7 @@ namespace gz
           unsigned int, unsigned int, const std::string&)> NewFrameListener;
 
       /// \brief Destructor
-      public: virtual ~Camera() { }
+      public: virtual ~Camera();
 
       /// \brief Get the image width in pixels
       /// \return The image width in pixels

include/gz/rendering/Capsule.hh

@@ -19,6 +19,7 @@
 #define GZ_RENDERING_CAPSULE_HH_
 
 #include "gz/rendering/config.hh"
+#include "gz/rendering/Export.hh"
 #include "gz/rendering/Geometry.hh"
 #include "gz/rendering/Object.hh"
 
@@ -33,7 +34,7 @@ namespace gz
       public virtual Geometry
     {
       /// \brief Destructor
-      public: virtual ~Capsule() { }
+      public: virtual ~Capsule();
 
       /// \brief Set the radius of the capsule
       public: virtual void SetRadius(double _radius) = 0;

include/gz/rendering/CompositeVisual.hh

@@ -33,7 +33,7 @@ namespace gz
       public virtual Visual
     {
       /// \brief Destructor
-      public: virtual ~CompositeVisual() { }
+      public: virtual ~CompositeVisual();
     };
     }
   }

include/gz/rendering/DepthCamera.hh

@@ -39,7 +39,7 @@ namespace gz
           unsigned int, unsigned int, const std::string&)> NewFrameListener;
 
       /// \brief Destructor
-      public: virtual ~DepthCamera() { }
+      public: virtual ~DepthCamera();
 
       /// \brief Create a texture which will hold the depth data
       public: virtual void CreateDepthTexture() = 0;

include/gz/rendering/Geometry.hh

@@ -36,7 +36,7 @@ namespace gz
       public virtual Object
     {
       /// \brief Destructor
-      public: virtual ~Geometry() { }
+      public: virtual ~Geometry();
 
       /// \brief Determine if this Geometry is attached to a Visual
       /// \return True if this Geometry has a parent Visual

include/gz/rendering/GizmoVisual.hh

@@ -35,7 +35,7 @@ namespace gz
       public virtual CompositeVisual
     {
       /// \brief Destructor
-      public: virtual ~GizmoVisual() { }
+      public: virtual ~GizmoVisual();
 
       /// \brief Set the transform mode of the gizmo. This controls the visual
       /// appearance of the gizmo. Only the visuals in the specified mode will

include/gz/rendering/GpuRays.hh

@@ -42,7 +42,7 @@ namespace gz
           unsigned int, unsigned int, const std::string&)> NewFrameListener;
 
       /// \brief Destructor
-      public: virtual ~GpuRays() { }
+      public: virtual ~GpuRays();
 
       /// \brief All things needed to get back z buffer for gpu rays data.
       /// \return Array of gpu rays data.

include/gz/rendering/Grid.hh

@@ -35,7 +35,7 @@ namespace gz
       public virtual Geometry
     {
       /// \brief Destructor
-      public: virtual ~Grid() { }
+      public: virtual ~Grid() = 0;
 
       /// \brief Set the number of cells on a planar grid
       /// \param[in] _count The number of cells

include/gz/rendering/InertiaVisual.hh

@@ -36,7 +36,7 @@ namespace gz
       public virtual Visual
     {
       /// \brief Destructor
-      public: virtual ~InertiaVisual() {}
+      public: virtual ~InertiaVisual();
 
       /// \brief Set the inertial component of the visual
       /// \param[in] _inertial Inertial component of the visual

include/gz/rendering/JointVisual.hh

@@ -70,7 +70,7 @@ namespace gz
       public virtual Visual
     {
       /// \brief Destructor
-      public: virtual ~JointVisual() {}
+      public: virtual ~JointVisual();
 
       /// \brief Create an axis and attach it to the joint visual.
       /// \param[in] _axis Axis vector.

include/gz/rendering/Light.hh

@@ -33,7 +33,7 @@ namespace gz
       public virtual Node
     {
       /// \brief Destructor
-      public: virtual ~Light() { }
+      public: virtual ~Light();
 
       /// \brief Get the diffuse color
       /// \return The diffuse color
@@ -122,7 +122,7 @@ namespace gz
       public virtual Light
     {
       /// \brief Destructor
-      public: virtual ~DirectionalLight() { }
+      public: virtual ~DirectionalLight();
 
       /// \brief Get the direction of the light
       /// \return The direction of the light
@@ -145,7 +145,7 @@ namespace gz
       public virtual Light
     {
       /// \brief Destructor
-      public: virtual ~PointLight() { }
+      public: virtual ~PointLight();
     };
 
     /// \class SpotLight Light.hh gz/rendering/Light.hh
@@ -154,7 +154,7 @@ namespace gz
       public virtual Light
     {
       /// \brief Destructor
-      public: virtual ~SpotLight() { }
+      public: virtual ~SpotLight();
 
       /// \brief Get direction of the light
       /// \return The direction of the light

include/gz/rendering/LightVisual.hh

@@ -50,7 +50,7 @@ namespace gz
       public virtual Visual
     {
       /// \brief Descructor
-      public: virtual ~LightVisual() {}
+      public: virtual ~LightVisual();
 
       /// \brief set type of the light
       /// \param[in] _type type of the light

include/gz/rendering/Material.hh

@@ -49,7 +49,7 @@ namespace gz
       public virtual Object
     {
       /// \brief Destructor
-      public: virtual ~Material() { }
+      public: virtual ~Material();
 
       /// \brief Determine if lighting affects this material
       /// \return True if lighting affects this material

include/gz/rendering/Mesh.hh

@@ -38,7 +38,7 @@ namespace gz
       public virtual Geometry
     {
       /// \brief Destructor
-      public: virtual ~Mesh() { }
+      public: virtual ~Mesh();
 
       /// \brief Check whether the mesh has skeleton
       /// \return True if the mesh has skeleton
@@ -136,7 +136,7 @@ namespace gz
       public virtual Object
     {
       /// \brief Destructor
-      public: virtual ~SubMesh() { }
+      public: virtual ~SubMesh();
 
       /// \brief Get the currently assigned material
       /// \return The currently assigned material

include/gz/rendering/Node.hh

@@ -52,7 +52,7 @@ namespace gz
       public virtual Object
     {
       /// \brief Destructor
-      public: virtual ~Node() { }
+      public: virtual ~Node();
 
       /// \brief Determine if this Node is attached to another Node.
       /// \return True if this Node has a parent Node

include/gz/rendering/Object.hh

@@ -34,7 +34,7 @@ namespace gz
     class GZ_RENDERING_VISIBLE Object
     {
       /// \brief Destructor
-      public: virtual ~Object() { }
+      public: virtual ~Object();
 
       /// \brief Get the object ID. This ID will be unique across all objects
       /// inside a given scene, but necessarily true for objects across

include/gz/rendering/ParticleEmitter.hh

@@ -59,7 +59,7 @@ namespace gz
       public virtual Visual
     {
       /// \brief Destructor
-      public: virtual ~ParticleEmitter() {}
+      public: virtual ~ParticleEmitter();
 
       /// \brief \brief Get the emitter type.
       /// \return Emitter type.

include/gz/rendering/RayQuery.hh

@@ -64,7 +64,7 @@ namespace gz
         : public virtual Object
     {
       /// \brief Destructor
-      public: virtual ~RayQuery() { }
+      public: virtual ~RayQuery();
 
       /// \brief Set ray origin
       /// \param[in] _origin Ray origin

include/gz/rendering/RenderEngine.hh

@@ -37,7 +37,7 @@ namespace gz
     class GZ_RENDERING_VISIBLE RenderEngine
     {
       /// \brief Destructor
-      public: virtual ~RenderEngine() { }
+      public: virtual ~RenderEngine();
 
       /// \brief Load any necessary resources to set up render-engine. This
       /// should called before any other function.

include/gz/rendering/RenderPass.hh

@@ -35,7 +35,7 @@ namespace gz
       : public virtual Object
     {
       /// \brief Destructor
-      public: virtual ~RenderPass() { }
+      public: virtual ~RenderPass();
 
       /// \brief Set to enable or disable the render pass
       /// \param[in] _enabled True to enable the render pass, false to disable.

include/gz/rendering/RenderTarget.hh

@@ -38,7 +38,7 @@ namespace gz
       public virtual Object
     {
       /// \brief Destructor
-      public: virtual ~RenderTarget() { }
+      public: virtual ~RenderTarget();
 
       /// \brief Get render target width in pixels
       /// \return The render target width in pixels
@@ -104,7 +104,7 @@ namespace gz
       public virtual RenderTarget
     {
       /// \brief Destructor
-      public: virtual ~RenderTexture() { }
+      public: virtual ~RenderTexture();
 
       /// \brief Returns the OpenGL texture Id. A valid Id is returned only
       // if this is an OpenGL render texture
@@ -127,7 +127,7 @@ namespace gz
       public virtual RenderTarget
     {
       /// \brief Destructor
-      public: virtual ~RenderWindow() { }
+      public: virtual ~RenderWindow();
 
       /// \brief Get the window handle that the render window is attached to.
       /// \return Window handle

include/gz/rendering/Scene.hh

@@ -48,7 +48,7 @@ namespace gz
     class GZ_RENDERING_VISIBLE Scene
     {
       /// \brief Destructor
-      public: virtual ~Scene() { }
+      public: virtual ~Scene();
 
       /// \brief Load scene-specific resources
       public: virtual void Load() = 0;

include/gz/rendering/SegmentationCamera.hh

@@ -52,7 +52,7 @@ namespace gz
       public virtual Camera
     {
       /// \brief Destructor
-      public: virtual ~SegmentationCamera() { }
+      public: virtual ~SegmentationCamera();
 
       /// \brief Create a texture which will hold the segmentation data
       public: virtual void CreateSegmentationTexture() = 0;

include/gz/rendering/Sensor.hh

@@ -33,7 +33,7 @@ namespace gz
       public virtual Node
     {
       /// \brief Sensor
-      public: virtual ~Sensor() { }
+      public: virtual ~Sensor();
 
       /// \brief Set visibility mask
       /// \param[in] _mask Visibility mask

include/gz/rendering/Storage.hh

@@ -57,7 +57,7 @@ namespace gz
       typedef std::shared_ptr<const T> ConstTPtr;
 
       /// \brief Destructor
-      public: virtual ~Map() { }
+      public: virtual ~Map() = default;
 
       /// \brief Get the number of elements in this map
       /// \return The number of elements in this map
@@ -122,7 +122,7 @@ namespace gz
       typedef std::shared_ptr<const T> ConstTPtr;
 
       /// \brief Destructor
-      public: virtual ~Store() { }
+      public: virtual ~Store() = default;
 
       /// \brief Get number of elements in this store
       /// \return The number of elements in this store
@@ -244,7 +244,7 @@ namespace gz
       typedef std::shared_ptr<const TStore> ConstTStorePtr;
 
       /// \brief Destructor
-      public: virtual ~CompositeStore() { }
+      public: virtual ~CompositeStore() = default;
 
       /// \brief Get number of Stores
       /// \return The number of Stores
@@ -291,7 +291,7 @@ namespace gz
     class GZ_RENDERING_VISIBLE StoreWrapper :
       public Store<T>
     {
-      public: virtual ~StoreWrapper() { }
+      public: virtual ~StoreWrapper() = default;
     };
 
 // armhf failed to build with this code. It can not be removed for the rest

include/gz/rendering/Text.hh

@@ -66,7 +66,7 @@ namespace gz
       public: Text() = default;
 
       /// \brief Destructor
-      public: virtual ~Text() = default;
+      public: virtual ~Text();
 
       /// \brief Set the font.
       /// \param[in] _font Name of the font

include/gz/rendering/ThermalCamera.hh

@@ -41,7 +41,7 @@ namespace gz
       public virtual Camera
     {
       /// \brief Destructor
-      public: virtual ~ThermalCamera() { }
+      public: virtual ~ThermalCamera();
 
       /// \brief Set the ambient temperature of the environment
       /// \param[in] _ambient Ambient temperature in kelvin

include/gz/rendering/ViewController.hh

@@ -35,7 +35,7 @@ namespace gz
     class GZ_RENDERING_VISIBLE ViewController
     {
       /// \brief Destructor
-      public: virtual ~ViewController() { }
+      public: virtual ~ViewController();
 
       /// \brief Set the camera that will be controlled by this view controller.
       /// \param[in] _camera Camera to control

include/gz/rendering/Visual.hh

@@ -34,7 +34,7 @@ namespace gz
       public virtual Node
     {
       /// \brief Destructor
-      public: virtual ~Visual() { }
+      public: virtual ~Visual();
 
       /// \brief Get the number of geometries attached to this visual
       /// \return The number of geometries attached to this visual

include/gz/rendering/WideAngleCamera.hh

@@ -38,7 +38,7 @@ namespace gz
       public virtual Camera
     {
       /// \brief Destructor
-      public: virtual ~WideAngleCamera() { }
+      public: virtual ~WideAngleCamera();
 
       /// \brief Set the camera lens to use for this wide angle camera
       /// \param[in] _lens Camera lens to set