Skip to content

Commit 528c0b9

Browse files
committed
spring-projectsGH-2198: Observability Doc Gen Polishing
1 parent c6bbba8 commit 528c0b9

File tree

5 files changed

+28
-120
lines changed

5 files changed

+28
-120
lines changed

build.gradle

+25-24
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
buildscript {
2-
ext.kotlinVersion = '1.7.0'
2+
ext.kotlinVersion = '1.7.20'
33
ext.isCI = System.getenv('GITHUB_ACTION') || System.getenv('bamboo_buildKey')
44
repositories {
55
mavenCentral()
@@ -67,7 +67,7 @@ ext {
6767
junitJupiterVersion = '5.9.1'
6868
kafkaVersion = '3.3.1'
6969
log4jVersion = '2.19.0'
70-
micrometerDocsVersion = "1.0.0-RC1"
70+
micrometerDocsVersion = "1.0.0-SNAPSHOT"
7171
micrometerVersion = '1.10.0-RC1'
7272
micrometerTracingVersion = '1.0.0-RC1'
7373
mockitoVersion = '4.8.0'
@@ -309,10 +309,6 @@ subprojects { subproject ->
309309
project ('spring-kafka') {
310310
description = 'Spring Kafka Support'
311311

312-
configurations {
313-
adoc
314-
}
315-
316312
dependencies {
317313
api 'org.springframework:spring-context'
318314
api 'org.springframework:spring-messaging'
@@ -353,25 +349,8 @@ project ('spring-kafka') {
353349
testImplementation 'io.micrometer:micrometer-tracing-test'
354350
testImplementation 'io.micrometer:micrometer-tracing-integration-test'
355351

356-
adoc "io.micrometer:micrometer-docs-generator:$micrometerDocsVersion"
357-
}
358-
359-
def inputDir = file('src/main/java/org/springframework/kafka/support/micrometer').absolutePath
360-
def outputDir = rootProject.file('spring-kafka-docs/src/main/asciidoc').absolutePath
361-
362-
task generateObservabilityDocs(type: JavaExec) {
363-
onlyIf { !isCI }
364-
mainClass = 'io.micrometer.docs.DocsGeneratorCommand'
365-
inputs.dir(inputDir)
366-
outputs.dir(outputDir)
367-
classpath configurations.adoc
368-
args inputDir, '.*', outputDir
369352
}
370353

371-
// javadoc {
372-
// finalizedBy generateObservabilityMetricsDocs, generateObservabilitySpansDocs
373-
// }
374-
375354
}
376355

377356
project ('spring-kafka-test') {
@@ -439,10 +418,12 @@ sonarqube {
439418

440419
configurations {
441420
asciidoctorExtensions
421+
micrometerDocs
442422
}
443423

444424
dependencies {
445425
asciidoctorExtensions "io.spring.asciidoctor.backends:spring-asciidoctor-backends:${springAsciidoctorBackendsVersion}"
426+
micrometerDocs "io.micrometer:micrometer-docs-generator:$micrometerDocsVersion"
446427
}
447428

448429
task prepareAsciidocBuild(type: Sync) {
@@ -452,8 +433,28 @@ task prepareAsciidocBuild(type: Sync) {
452433
into "$buildDir/asciidoc"
453434
}
454435

436+
def observationInputDir = file('spring-kafka/src/main/java/org/springframework/kafka/support/micrometer').absolutePath
437+
def generatedDocsDir = file("$buildDir/docs/generated").absolutePath
438+
439+
task generateObservabilityDocs(type: JavaExec) {
440+
mainClass = 'io.micrometer.docs.DocsGeneratorCommand'
441+
inputs.dir(observationInputDir)
442+
outputs.dir(generatedDocsDir)
443+
classpath configurations.micrometerDocs
444+
args observationInputDir, /.+/, generatedDocsDir
445+
}
446+
447+
task filterMetricsDocsContent(type: Copy) {
448+
dependsOn generateObservabilityDocs
449+
from generatedDocsDir
450+
include '_*.adoc'
451+
into generatedDocsDir
452+
rename { filename -> filename.replace '_', '' }
453+
filter { line -> line.replaceAll('org.springframework.kafka.support.micrometer.', '').replaceAll('^Fully qualified n', 'N') }
454+
}
455+
455456
asciidoctorPdf {
456-
dependsOn prepareAsciidocBuild
457+
dependsOn prepareAsciidocBuild, filterMetricsDocsContent
457458
baseDirFollowsSourceFile()
458459
configurations 'asciidoctorExt'
459460

spring-kafka-docs/src/main/asciidoc/_conventions.adoc

-11
This file was deleted.

spring-kafka-docs/src/main/asciidoc/_metrics.adoc

-44
This file was deleted.

spring-kafka-docs/src/main/asciidoc/_spans.adoc

-38
This file was deleted.

spring-kafka-docs/src/main/asciidoc/appendix.adoc

+3-3
Original file line numberDiff line numberDiff line change
@@ -53,11 +53,11 @@ The test scope dependencies are only needed if you are using the embedded Kafka
5353
[[observation-gen]]
5454
== Micrometer Observation Documentation
5555

56-
include::./_metrics.adoc[]
56+
include::../docs/generated/metrics.adoc[]
5757

58-
include::./_spans.adoc[]
58+
include::../docs/generated/spans.adoc[]
5959

60-
include::./_conventions.adoc[]
60+
include::../docs/generated/conventions.adoc[]
6161

6262
[appendix]
6363
[[history]]

0 commit comments

Comments
 (0)