Skip to content

Commit 44740a9

Browse files
committed
Assert length of input connections, instead of inputs when disconnecting steps
Inputs become runtime inputs due to: ``` if "inputs" in step_dict: for input_dict in step_dict["inputs"]: step_input = model.WorkflowStepInput(step) ... ``` in galaxy.managers.workflows.WorkflowContentsManager. I guess it is debatable whether we want to adjust the test or WorkflowContentsManager for disconnected steps. When exported to .ga these are exactly the same (minus uuid differences).
1 parent adb5849 commit 44740a9

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

test/integration/test_workflow_refactoring.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,7 @@ def test_basic_refactoring_types(self):
120120
assert self._latest_workflow.step_by_label("new_param2").position["left"] == 2
121121

122122
assert len(self._latest_workflow.step_by_label("first_cat").inputs) == 1
123+
assert len(self._latest_workflow.step_by_label("first_cat").inputs[0].connections) == 1
123124
actions = [
124125
{
125126
"action_type": "disconnect",
@@ -128,7 +129,8 @@ def test_basic_refactoring_types(self):
128129
}
129130
]
130131
self._refactor(actions)
131-
assert len(self._latest_workflow.step_by_label("first_cat").inputs) == 0
132+
assert len(self._latest_workflow.step_by_label("first_cat").inputs) == 1
133+
assert len(self._latest_workflow.step_by_label("first_cat").inputs[0].connections) == 0
132134

133135
actions = [
134136
{

0 commit comments

Comments
 (0)