Fix shutdown in case of errors during initialization

laanwj · furszy · commit 73431436952f · 2021-02-05T17:12:43.000-03:00
PR bitcoin#10286 introduced a few steps which are not robust to early shutdown in initialization. Stumbled upon this with bitcoin#11781, not sure if there are other scenarios that can trigger it, but it's harden against this in any case.
diff --git a/src/validationinterface.cpp b/src/validationinterface.cpp
@@ -67,7 +67,9 @@ void CMainSignals::UnregisterBackgroundSignalScheduler() {
 }
 
 void CMainSignals::FlushBackgroundCallbacks() {
-    m_internals->m_schedulerClient.EmptyQueue();
+    if (m_internals) {
+        m_internals->m_schedulerClient.EmptyQueue();
+    }
 }
 
 CMainSignals& GetMainSignals()

Original file line number	Diff line number	Diff line change
`@@ -67,7 +67,9 @@ void CMainSignals::UnregisterBackgroundSignalScheduler() {`
`67`	`67`	`}`
`68`	`68`
`69`	`69`	`void CMainSignals::FlushBackgroundCallbacks() {`
`70`		`- m_internals->m_schedulerClient.EmptyQueue();`
	`70`	`+ if (m_internals) {`
	`71`	`+ m_internals->m_schedulerClient.EmptyQueue();`
	`72`	`+ }`
`71`	`73`	`}`
`72`	`74`
`73`	`75`	`CMainSignals& GetMainSignals()`